fix: gcb builder incorrectly assumes target project from worker pool project#9725
Merged
Darien-Lin merged 2 commits intoGoogleContainerTools:mainfrom Mar 5, 2025
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
bogdannazarenko
force-pushed
the
gcb-private-pool
branch
from
ec41938 to
607c9fa
Compare
bogdannazarenko
force-pushed
the
gcb-private-pool
branch
from
607c9fa to
e4e168c
Compare
bogdannazarenko
changed the title
bogdannazarenko
force-pushed
the
gcb-private-pool
branch
from
e4e168c to
9c46fd2
Compare
bogdannazarenko
force-pushed
the
gcb-private-pool
branch
from
9c46fd2 to
3b443e2
Compare
bogdannazarenko
force-pushed
the
gcb-private-pool
branch
from
3b443e2 to
1734ad5
Compare
Darien-Lin
previously approved these changes
Feb 24, 2025
Contributor
|
seems that there are some errors from the workflow: File is not Complaining about the import in the test it seems. Can you update? |
Darien-Lin
dismissed
their stale review
File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/GoogleContainerTools/skaffold) (gci)
Darien-Lin
requested changes
Feb 25, 2025
bogdannazarenko
force-pushed
the
gcb-private-pool
branch
from
1734ad5 to
ae3794c
Compare
Darien-Lin
approved these changes
Mar 5, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9730
Related: N/A
Merge before/after: N/A
Description