fix: port-forward error logs failed to port forward#9728
Merged
Darien-Lin merged 5 commits intoGoogleContainerTools:mainfrom Feb 26, 2025
foriequal0:fix/port-forward
Merged
fix: port-forward error logs failed to port forward#9728Darien-Lin merged 5 commits intoGoogleContainerTools:mainfrom foriequal0:fix/port-forward
failed to port forward#9728Darien-Lin merged 5 commits intoGoogleContainerTools:mainfrom
foriequal0:fix/port-forward
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
foriequal0
changed the title
failed to port forwardfailed to port forward
Reflect changes in `os.Process` introduced in Go 1.23
Darien-Lin
reviewed
Feb 26, 2025
Darien-Lin
previously approved these changes
Feb 26, 2025
Darien-Lin
approved these changes
Feb 26, 2025
Contributor
Darien-Lin
left a comment
Darien-Lin
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for making the changes and contributing to the code base!
Contributor
Author
|
Thank you for the review! |
Darien-Lin
pushed a commit
that referenced
this pull request
Mar 19, 2025
* fix: port-forward error logs `failed to port forward` Reflect changes in `os.Process` introduced in Go 1.23 * use `reflect` to make it future proof(?) * Add safeguards to call FieldByName * Add basic test to getHandleFromProcess * Fix copyright year Co-authored-by: SeongChan Lee <foriequal@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9710
Description
Golang has changed os.Process structure since 1.23
cs.opensource.google/go/go/+/refs/tags/go1.22.0:src/os/exec.go;l=21
cs.opensource.google/go/go/+/refs/tags/go1.23.0:src/os/exec.go;l=58
so this unpack doesn't work, lead to
failed to port-forwardmessage loop.