Add v1alpha3 Config#982
Merged
priyawadhwa merged 3 commits intoGoogleContainerTools:masterfrom Sep 13, 2018
Merged
Conversation
I added a v1alpha3 version of the skaffold config, since adding different buildcontexts to the kaniko builder requires a breaking config change. Now, new buildcontexts can be easily added to the KanikoBuildContext type. I also added a transform function so that 'skaffold fix' can convert v1alpha2 configs to v1alpha3, and fixed unit tests to pass with the new config. This is part 1 of 3 PRs to incorporate more kaniko buildcontexts into the kaniko builder.
priyawadhwa
force-pushed
the
config
branch
3 times, most recently
from
ebdf975 to
d085b6c
Compare
balopat
reviewed
Sep 13, 2018
integration/run_test.go
Outdated
| directory: "testdata/v1alpha1", | ||
| }, | ||
| { | ||
| name: "test v1alpha2 to v1alpha3 kaniko fix", |
Contributor
There was a problem hiding this comment.
nit: we won't need kaniko here I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a v1alpha3 version of the skaffold config, since adding
different buildcontexts to the kaniko builder requires a breaking config
change.
Now, new buildcontexts can be easily added to the KanikoBuildContext type.
I also added a transform function so that 'skaffold fix' can convert
v1alpha2 configs to v1alpha3, and fixed unit tests to pass with the new
config.
This is part 1 of 3 PRs to incorporate more kaniko buildcontexts into
the kaniko builder.
Sorry this PR is so huge (it's mostly just changing v1alpha2 to v1alpha3 across the code), so thank you in advance to whoever looks at it!!