Auto configure authentication helper for gcr.io

[dgageot]

Fixes #966

Signed-off-by: David Gageot david@gageot.net

[dlorenc]

Do we make sure gcloud is installed anywhere?

It's also possible to use the "gcr" credential helper which handles it's own authentication without gcloud. I'm not sure how common that is, though.

[dgageot]

I'm going to add the check indeed.

I'd rather ignore that "gcr" credential helper can be used since It's not the solution documented here
Users can still use it if they want though.

[dgageot]

@dlorenc it should be good now.

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

[dlorenc]

I added some debug logging on why the helper get's skipped, but now I've made the CLA bot angry :(

I confirm that I'm OK with my commit being used :)

[dgageot]

I'm ok with @dlorenc's commit ;-)

[codecov-io]

Codecov Report

Merging #989 into master will decrease coverage by 0.2%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
- Coverage   40.64%   40.44%   -0.21%     
==========================================
  Files          68       69       +1     
  Lines        2967     3019      +52     
==========================================
+ Hits         1206     1221      +15     
- Misses       1637     1672      +35     
- Partials      124      126       +2

Impacted Files	Coverage Δ
pkg/skaffold/docker/auth.go	52.38% <0%> (-1.28%)	⬇️
pkg/skaffold/gcp/auth.go	100% <100%> (ø)
pkg/skaffold/deploy/deploy.go	25% <0%> (-75%)	⬇️
pkg/skaffold/watch/changes.go	70.37% <0%> (-5.63%)	⬇️
pkg/skaffold/deploy/helm.go	63.95% <0%> (-0.19%)	⬇️
pkg/skaffold/runner/runner.go	54.63% <0%> (+0.18%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba2b78...73b23a5. Read the comment docs.