chore: delete webhooks#9999
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request completely removes the previously existing webhook infrastructure responsible for generating and deploying docs previews. This cleanup targets components that are no longer actively utilized, streamlining the codebase by eliminating deprecated deployment and application logic. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the documentation preview webhooks, which are no longer used. This is a good cleanup effort. However, it appears that some files related to the webhook functionality were not included in this pull request. To complete the removal and avoid leaving dead code in the repository, I recommend also deleting the following files:
pkg/webhook/constants/constants.gopkg/webhook/gcs/gcs.gopkg/webhook/github/github.gopkg/webhook/labels/labels.godeploy/docs-v1/preview.shdeploy/docs-v2/preview.sh
After deleting these files, their parent directories can also be removed if they become empty. This will ensure the feature is removed completely.
kkarrenn
left a comment
There was a problem hiding this comment.
Thanks for the change! Let's also make sure it's reflected in the existing production system.
3e7c030
into
GoogleContainerTools:main
delete webhooks used to display what the docs would look like with a PR change
delete webhooks used to display what the docs would look like with a PR change
delete webhooks used to display what the docs would look like with a PR change
* chore: delete webhooks (#9999) delete webhooks used to display what the docs would look like with a PR change * chore: bump github.com/cloudflare/circl from 1.6.1 to 1.6.3 (#9993) Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl) from 1.6.1 to 1.6.3. - [Release notes](https://github.com/cloudflare/circl/releases) - [Commits](cloudflare/circl@v1.6.1...v1.6.3) --- updated-dependencies: - dependency-name: github.com/cloudflare/circl dependency-version: 1.6.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Migration to Kokoro instances (#9991) * debug migrating to Kokoro instances - pared down PR * switch to new project in presubmit.sh * pared down to just one test * tag skaffold-builder image with commit and push to AR * use buildx with --load * jib errors * remove wrong project * jib updates * chore: bump flask from 2.2.5 to 3.1.3 in /integration/examples/hot-reload/python (#9989) chore: bump flask in /integration/examples/hot-reload/python Bumps [flask](https://github.com/pallets/flask) from 2.2.5 to 3.1.3. - [Release notes](https://github.com/pallets/flask/releases) - [Changelog](https://github.com/pallets/flask/blob/main/CHANGES.rst) - [Commits](pallets/flask@2.2.5...3.1.3) --- updated-dependencies: - dependency-name: flask dependency-version: 3.1.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump rack from 2.2.20 to 2.2.22 in /examples/ruby/backend (#9981) Bumps [rack](https://github.com/rack/rack) from 2.2.20 to 2.2.22. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md) - [Commits](rack/rack@v2.2.20...v2.2.22) --- updated-dependencies: - dependency-name: rack dependency-version: 2.2.22 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description
Delete docs preview webhooks - no longer used