Skip to content

chore: delete webhooks#9999

Merged
menahyouyeah merged 2 commits intoGoogleContainerTools:mainfrom
menahyouyeah:webhook
Mar 3, 2026
Merged

chore: delete webhooks#9999
menahyouyeah merged 2 commits intoGoogleContainerTools:mainfrom
menahyouyeah:webhook

Conversation

@menahyouyeah
Copy link
Copy Markdown
Contributor

Description
Delete docs preview webhooks - no longer used

@menahyouyeah menahyouyeah requested a review from a team as a code owner March 3, 2026 16:32
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request completely removes the previously existing webhook infrastructure responsible for generating and deploying docs previews. This cleanup targets components that are no longer actively utilized, streamlining the codebase by eliminating deprecated deployment and application logic.

Highlights

  • Webhook Infrastructure Deletion: The entire set of files comprising the docs preview webhook infrastructure, including Dockerfiles, Kubernetes deployment manifests, Skaffold configurations, and Go source code for webhook logic, Kubernetes interactions, and GCS logging, has been removed.
  • Deprecated Functionality Removal: This removal addresses components that are explicitly stated as "no longer used" for docs preview functionality, streamlining the codebase.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • deploy/webhook-v2/Dockerfile
    • Removed the Dockerfile for the v2 docs preview webhook.
  • deploy/webhook-v2/cloudbuild.yaml
    • Removed the Cloud Build configuration for the v2 docs preview webhook.
  • deploy/webhook-v2/deployment.yaml
    • Removed the Kubernetes deployment manifest for the v2 docs preview webhook.
  • deploy/webhook-v2/skaffold.yaml
    • Removed the Skaffold configuration for the v2 docs preview webhook.
  • deploy/webhook/Dockerfile
    • Removed the Dockerfile for the original docs preview webhook.
  • deploy/webhook/cloudbuild.yaml
    • Removed the Cloud Build configuration for the original docs preview webhook.
  • deploy/webhook/deployment.yaml
    • Removed the Kubernetes deployment manifest for the original docs preview webhook.
  • deploy/webhook/skaffold.yaml
    • Removed the Skaffold configuration for the original docs preview webhook.
  • pkg/webhook/kubernetes/cleanup.go
    • Removed the Go source file responsible for Kubernetes deployment cleanup.
  • pkg/webhook/kubernetes/deployment.go
    • Removed the Go source file containing Kubernetes deployment creation and stabilization logic.
  • pkg/webhook/kubernetes/service.go
    • Removed the Go source file for Kubernetes service creation and external IP retrieval.
  • webhook/webhook.go
    • Removed the main Go application file for handling GitHub webhook events.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the documentation preview webhooks, which are no longer used. This is a good cleanup effort. However, it appears that some files related to the webhook functionality were not included in this pull request. To complete the removal and avoid leaving dead code in the repository, I recommend also deleting the following files:

  • pkg/webhook/constants/constants.go
  • pkg/webhook/gcs/gcs.go
  • pkg/webhook/github/github.go
  • pkg/webhook/labels/labels.go
  • deploy/docs-v1/preview.sh
  • deploy/docs-v2/preview.sh

After deleting these files, their parent directories can also be removed if they become empty. This will ensure the feature is removed completely.

Copy link
Copy Markdown

@kkarrenn kkarrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Let's also make sure it's reflected in the existing production system.

@menahyouyeah menahyouyeah merged commit 3e7c030 into GoogleContainerTools:main Mar 3, 2026
16 of 20 checks passed
menahyouyeah added a commit to menahyouyeah/skaffold that referenced this pull request Mar 3, 2026
delete webhooks used to display what the docs would look like with a PR change
@menahyouyeah menahyouyeah mentioned this pull request Mar 3, 2026
menahyouyeah added a commit to menahyouyeah/skaffold that referenced this pull request Mar 3, 2026
delete webhooks used to display what the docs would look like with a PR change
menahyouyeah added a commit to menahyouyeah/skaffold that referenced this pull request Mar 3, 2026
delete webhooks used to display what the docs would look like with a PR change
@menahyouyeah menahyouyeah mentioned this pull request Mar 3, 2026
alphanota pushed a commit that referenced this pull request Mar 4, 2026
* chore: delete webhooks (#9999)

delete webhooks used to display what the docs would look like with a PR change

* chore: bump github.com/cloudflare/circl from 1.6.1 to 1.6.3 (#9993)

Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl) from 1.6.1 to 1.6.3.
- [Release notes](https://github.com/cloudflare/circl/releases)
- [Commits](cloudflare/circl@v1.6.1...v1.6.3)

---
updated-dependencies:
- dependency-name: github.com/cloudflare/circl
  dependency-version: 1.6.3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Migration to Kokoro instances (#9991)

* debug migrating to Kokoro instances - pared down PR

* switch to new project in presubmit.sh

* pared down to just one test

* tag skaffold-builder image with commit and push to AR

* use buildx with --load

* jib errors

* remove wrong project

* jib updates

* chore: bump flask from 2.2.5 to 3.1.3 in /integration/examples/hot-reload/python (#9989)

chore: bump flask in /integration/examples/hot-reload/python

Bumps [flask](https://github.com/pallets/flask) from 2.2.5 to 3.1.3.
- [Release notes](https://github.com/pallets/flask/releases)
- [Changelog](https://github.com/pallets/flask/blob/main/CHANGES.rst)
- [Commits](pallets/flask@2.2.5...3.1.3)

---
updated-dependencies:
- dependency-name: flask
  dependency-version: 3.1.3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: bump rack from 2.2.20 to 2.2.22 in /examples/ruby/backend (#9981)

Bumps [rack](https://github.com/rack/rack) from 2.2.20 to 2.2.22.
- [Release notes](https://github.com/rack/rack/releases)
- [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md)
- [Commits](rack/rack@v2.2.20...v2.2.22)

---
updated-dependencies:
- dependency-name: rack
  dependency-version: 2.2.22
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants