[feat] Support for JSON_TABLE by ANeumann82 · Pull Request #2328 · JSQLParser/JSqlParser

ANeumann82 · 2025-10-15T19:20:52Z

No description provided.

manticore-projects

Great work and I do appreciate your effort and dedication. Thank you much!
A few small concerns though, nothing severe just the normal German nit-picking.

Kudos and cheers!

src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt

src/main/java/net/sf/jsqlparser/util/validation/validator/ExpressionValidator.java

src/main/java/net/sf/jsqlparser/util/deparser/SelectDeParser.java

src/main/java/net/sf/jsqlparser/util/deparser/ExpressionDeParser.java

src/main/java/net/sf/jsqlparser/statement/select/FromItemVisitorAdapter.java

src/main/java/net/sf/jsqlparser/statement/from/JsonTable.java

src/main/java/net/sf/jsqlparser/expression/json/JsonReturnType.java

src/main/java/net/sf/jsqlparser/expression/JsonQueryWrapperType.java

src/main/java/net/sf/jsqlparser/expression/ExpressionVisitorAdapter.java

ANeumann82 · 2025-10-17T14:50:10Z

Great work and I do appreciate your effort and dedication. Thank you much! A few small concerns though, nothing severe just the normal German nit-picking.

Kudos and cheers!

Keep the nit-picking coming :) There's still some features missing before I'll consider this PR ready for merge.

bhupi26 · 2025-10-31T22:51:17Z

_ No description provided. _

@ANeumann82 Great Work!! Can you please let me know the ETA for this change

manticore-projects · 2025-11-21T02:30:40Z

@ANeumann82: How can we move this forward together? What assistance can I provide please?

# Conflicts: # src/main/java/net/sf/jsqlparser/util/deparser/ExpressionDeParser.java # src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt

ANeumann82 · 2025-11-25T15:52:09Z

@manticore-projects Sorry for the long silence. I've been into a rabbit hole of JavaCC and other parsers...

I've updated the PR from the master branch, but now I get "code too large" in the generated "CCJsqlParserTokenManager.java".

Do you have any idea to work around that problem?

I don't know if there's anything we can do about that with the current JavaCC version. I'm currently looking into alternative parsers to maybe replace JavaCC in JSQLParser at some point, but that's not easy.

manticore-projects · 2025-11-26T00:15:58Z

@manticore-projects Sorry for the long silence. I've been into a rabbit hole of JavaCC and other parsers...

Have done that, have been there and you are welcome.
(I needed a proper SQL panel for our ETL Software, which made me dive into JSQLFormatter, which made me dive into JSQLParser, which made me dive into JavaCC -- and all I wanted was to move some data for our clients.)

I've updated the PR from the master branch, but now I get "code too large" in the generated "CCJsqlParserTokenManager.java".

I will lodge a case with the JavaCC team, maybe they can help.

Do you have any idea to work around that problem?

We have too many token apparently. I want to check first if the JavaCC team can help.
Otherwise we need to refactor the Grammar and avoid any useless token that is used not more than one time and in too specific productions only. I have had a deep discussion on that with the JavaCC team before on this topic.

I don't know if there's anything we can do about that with the current JavaCC version. I'm currently looking into alternative parsers to maybe replace JavaCC in JSQLParser at some point, but that's not easy.

I am most interested in this one too and dug deep already. Unfortunately there is not really any good alternative, but maybe CongoCC. Unfortunately there are some social issues around this project (or maybe with me). And also there still seems to be a (small?) performance penalty in the generated parser.

manticore-projects · 2025-12-01T11:23:47Z

Do you have any idea to work around that problem?

I am reworking the Tokens and the Reserved Keywords as we speak to free up the token manager.

manticore-projects · 2026-03-14T18:16:31Z

Greetings @ANeumann82, as promised I have completely reworked the token handling.
This should solve the "code too large" problem once and for all. We also have achieved much better performance.

So we should be able to proceed with your PR please.
@dengliming: in case you get bored and look for a challenge :-D

dengliming · 2026-03-14T22:52:36Z

Haha, thanks for the ping! :) I only took a quick look through this PR, but my main concern is more about the overall direction than the style details. Current master already seems to model JSON_TABLE through TableFunction/JsonTableFunction together with newer token handling, while this branch introduces a separate JsonTable FromItem path and expands the older token setup again.

It may be worth considering whether the remaining JSON_TABLE support here could be folded into the existing master-side model instead of keeping two parallel representations. That looks like it could simplify the visitor/deparser/validator side and may also help avoid running back into the older TokenManager size issues.

ANeumann82 · 2026-03-15T07:48:03Z

Hey @manticore-projects, thanks for the update. I'll take a look at this in the coming week or so.

@dengliming Yeah, I'll have to take a look at that. Seems like there was some JSON_TABLE functionality added a couple weeks ago, while my PR is a bit older. I'll take a look if and how I can consolidate that.

# Conflicts: # src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt

…e, formatJson for Body

manticore-projects · 2026-04-01T20:12:15Z

Greetings!

We are running to /home/runner/work/JSqlParser/JSqlParser/build/generated/javacc/net/sf/jsqlparser/parser/CCJSqlParserTokenManager.java:55: error: code too large issue again?!
How/where have you tested it?

ANeumann82 · 2026-04-01T20:25:08Z

Yeah, i've only tested it before I merged the latest changes from master into my branch. I've just fixed that. It's not nice, but it seems to work.

ANeumann82 · 2026-04-01T20:33:09Z

I'll take a look at the static code analysis issues tomorrow, not sure about the ubuntu-latest compile error though.

manticore-projects

Great stuff and work overall.
I only have 1 question on the grammar and it is optional. If there is no quick improvement possible, we could just go ahead.

(Ignore the Maven failures please, I will rip out this old garbage very soon anyways.)

src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt

manticore-projects · 2026-04-02T08:35:07Z

@ANeumann82: I would like to thank you very much for your work and effort, this is quite a chunk!

manticore-projects · 2026-04-02T16:42:51Z

Big thank you again!

ANeumann82 added 2 commits October 13, 2025 18:40

[feat] Initial support for JSON_TABLE

0b85753

[feat] Additional support for JSON_TABLE

8773eea

manticore-projects requested changes Oct 16, 2025

View reviewed changes

[chore] Code Review

0c55268

Merge branch 'master' into json_table_support

cb1654a

# Conflicts: # src/main/java/net/sf/jsqlparser/util/deparser/ExpressionDeParser.java # src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt

ANeumann82 added 5 commits March 15, 2026 11:58

Merge branch 'master' into json_table_support

81ccfa6

# Conflicts: # src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt

[chore] Started to add oracle JSON_TABLE features

d39df7f

[feat] Fixed onError for Oracle, added onEmptyClause, addedParsingTyp…

3908529

…e, formatJson for Body

[feat] Added EXISTS keyword

5775a78

[chore] spotless

96c40e1

ANeumann82 marked this pull request as ready for review April 1, 2026 19:49

ANeumann82 requested a review from manticore-projects April 1, 2026 19:49

ANeumann82 added 2 commits April 1, 2026 21:56

[chore] cleanup

8d3b1d6

Merge branch 'refs/heads/master' into json_table_support

ee3e4f4

[bugfix] Fixed token limit again...

3f5edea

manticore-projects requested changes Apr 2, 2026

View reviewed changes

src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt Show resolved Hide resolved

[chore] One more test, code cleanup

c65de44

manticore-projects merged commit c5e2fdc into JSQLParser:master Apr 2, 2026
4 of 7 checks passed

Uh oh!

Conversation

ANeumann82 commented Oct 15, 2025

Uh oh!

manticore-projects left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ANeumann82 commented Oct 17, 2025

Uh oh!

bhupi26 commented Oct 31, 2025

Uh oh!

manticore-projects commented Nov 21, 2025

Uh oh!

ANeumann82 commented Nov 25, 2025

Uh oh!

manticore-projects commented Nov 26, 2025

Uh oh!

manticore-projects commented Dec 1, 2025

Uh oh!

manticore-projects commented Mar 14, 2026

Uh oh!

dengliming commented Mar 14, 2026

Uh oh!

ANeumann82 commented Mar 15, 2026

Uh oh!

manticore-projects commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ANeumann82 commented Apr 1, 2026

Uh oh!

ANeumann82 commented Apr 1, 2026

Uh oh!

manticore-projects left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

manticore-projects commented Apr 2, 2026

Uh oh!

manticore-projects commented Apr 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

manticore-projects commented Apr 1, 2026 •

edited

Loading