Conversation
|
@copilot There really isn't a need for a runner for this work. Simply make the changes in the .cs file and update the documentation, then I can review the changes. |
|
@copilot please try again. |
Agent-Logs-Url: https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/sessions/7b42c504-036c-4afa-bada-baba0a8efd08 Co-authored-by: nicolaihenriksen <19572699+nicolaihenriksen@users.noreply.github.com>
Done. Commit
|
nicolaihenriksen
left a comment
There was a problem hiding this comment.
Looks good to me. @Keboo are you OK with this change?
Keboo
left a comment
There was a problem hiding this comment.
Looks good! The new materialDesignInternal XML namespace cleanly exposes the internal types, and the README documentation with the backward-compatibility warning is a nice touch. Approved.
Partially fixes #4029
Fixes #4030
Exposes a new XML namespace
http://materialdesigninxaml.net/winfx/xaml/themes-internal(prefix:materialDesignInternal) to make public types from the.Internalsub-namespaces accessible in XAML.Changes Made
src/MaterialDesignThemes.Wpf/Properties/AssemblyInfo.cs: AddedXmlnsPrefixandXmlnsDefinitionassembly attributes registering the newhttp://materialdesigninxaml.net/winfx/xaml/themes-internalnamespace, covering:MaterialDesignThemes.Wpf.InternalMaterialDesignThemes.Wpf.Converters.InternalMaterialDesignThemes.Wpf.Behaviors.InternalREADME.md: Added an "XML Namespaces" subsection under "Getting started" documenting both XML namespaces, with a warning that types from thematerialDesignInternalnamespace are not guaranteed to maintain backwards-compatibility between versions, and a usage example.Usage
To use the internal namespace in XAML, declare it as follows: