Closed
Conversation
leofang
added
P0
Contributor
|
Just for awareness, I unexpectedly saw these warnings the other day while trying out LLM NIMs for the first time. Not to dissuade you -- I think you can justify the change based on the length of deprecation -- but I think there are a lot of users who haven't migrated and this could have wider repercussions than anticipated. Example of where I saw this: https://gist.github.com/bdice/1de237b48370a29ef9d5c777ac2acc5e#file-gpt-oss-20b-log-L55 |
Member
Author
|
Based on an offline discussion with Bradley/Keith based on the above observation, we decided to not purge the trampolines in 12.9.x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of #795
Checklist