refactor: replace none equality checks with is/is not equivalents#970
Merged
cpcloud merged 1 commit intoNVIDIA:12.9.xfrom Sep 15, 2025
Merged
refactor: replace none equality checks with is/is not equivalents#970cpcloud merged 1 commit intoNVIDIA:12.9.xfrom
is/is not equivalents#970cpcloud merged 1 commit intoNVIDIA:12.9.xfrom
Conversation
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Member
|
/ok to test |
mdboom
approved these changes
Sep 15, 2025
Contributor
Author
|
It does change the code, because __pyx_v_x != Py_Nonewhen |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements proper None checks using
is/is not, contains code regenerated from https://github.com/NVIDIA/cuda-python-private/pull/146.