ci: python 3.13 free threading builds#986
Conversation
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
2 similar comments
|
/ok to test |
|
/ok to test |
ci/test-matrix.json
Outdated
| { "ARCH": "amd64", "PY_VER": "3.12", "CUDA_VER": "13.0.1", "LOCAL_CTK": "0", "GPU": "l4", "DRIVER": "latest" }, | ||
| { "ARCH": "amd64", "PY_VER": "3.13", "CUDA_VER": "12.9.1", "LOCAL_CTK": "0", "GPU": "l4", "DRIVER": "latest" }, | ||
| { "ARCH": "amd64", "PY_VER": "3.13", "CUDA_VER": "13.0.1", "LOCAL_CTK": "1", "GPU": "l4", "DRIVER": "latest" }, | ||
| { "ARCH": "amd64", "PY_VER": "3.13t", "CUDA_VER": "12.9.1", "LOCAL_CTK": "0", "GPU": "l4", "DRIVER": "latest" }, |
There was a problem hiding this comment.
This requires cuda-bindings 12.9.x to be rebuilt and merged first
There was a problem hiding this comment.
Ok, what needs to happen for that?
There was a problem hiding this comment.
Have a backport version of this PR merged first, as implied by our new shiny CI doc we fetch the 12.x wheels from the 12.9.x branch.
There was a problem hiding this comment.
Ok, I'll leave it out for now then.
leofang
added
P0
cpcloud
force-pushed
the
free-threading-builds
branch
from
b2a70a7 to
48ea7d4
Compare
|
/ok to test |
cpcloud
changed the title
This comment has been minimized.
This comment has been minimized.
|
Looks like I am probably missing a comma in some JSON. That's what I get for copypasta-ing! |
|
/ok to test |
|
Tests are currently not able to run because Unfortunately there's also no way to get that metadata at build time (see https://packaging.python.org/en/latest/specifications/dependency-specifiers/#dependency-specifiers for what's available. I tried them all, and saw nothing that indicated whether a build was a FT build). I'll have to come up with a WAR to skip installation of that dependency. |
…testing the FT builds
cpcloud
force-pushed
the
free-threading-builds
branch
from
de5815a to
96ee1c2
Compare
|
/ok to test |
|
Ah, I need to edit the build matrix I think. |
|
/ok to test |
|
Thanks, Phillip! Code-wise LGTM! A few questions on the next steps you have in mind:
|
|
Will do each of those in a separate PR! |
leofang
left a comment
leofang
left a comment
There was a problem hiding this comment.
Sounds good, thanks! We also need to backport this.
|
Ok, I will get started on the backport then. Merging. |
|
* ci: build free-threaded wheels * build(deps): bump cython lower bound * ci: enable freethreading for 3.13 in cibuildwheel * ci: bump cython lower bound in cuda_core * ci: skip tests that require llvmlite because it does not ship a free-threading build wheel * ci: remove filtering out of cuda-bindings artifacts * ci: remove redundant environment variable setting * ci: fix syntax errors in ci/test-matrix.json * ci: add optional dependency group to avoid installation of cupy when testing the FT builds * ci: remove 12.9.x from builds for now
* ci: build free-threaded wheels * build(deps): bump cython lower bound * ci: enable freethreading for 3.13 in cibuildwheel * ci: bump cython lower bound in cuda_core * ci: skip tests that require llvmlite because it does not ship a free-threading build wheel * ci: remove filtering out of cuda-bindings artifacts * ci: remove redundant environment variable setting * ci: fix syntax errors in ci/test-matrix.json * ci: add optional dependency group to avoid installation of cupy when testing the FT builds * ci: remove 12.9.x from builds for now
2 participants
Closes #132. Add CI wheel builds and test matrix entries for free-threaded builds.