Skip to content

Fixed conditional attribute evaluation for test #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tstager wants to merge 1 commit into
base: v2
Choose a base branch
from
+151 −1
Open

Fixed conditional attribute evaluation for test #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Plaster/Private/Test-ConditionAttribute.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,13 @@ function Test-ConditionAttribute {
}

try {
$res = @(Invoke-ExpressionImpl $Expression)
$expressionToEvaluate = $Expression

if ($manifestType -eq 'JSON') {
$expressionToEvaluate = $expressionToEvaluate -replace '\$\{(?!PLASTER_)([A-Za-z][A-Za-z0-9_]*)\}', '${PLASTER_PARAM_$1}'
}

$res = @(Invoke-ExpressionImpl $expressionToEvaluate)
[bool]$res[0]
} catch {
throw ($LocalizedData.ExpressionInvalidCondition_F3 -f $Expression, $Location, $_)
Expand Down
144 changes: 144 additions & 0 deletions tests/ConditionEval.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,4 +144,148 @@ Describe 'Condition Attribute Evaluation Tests' {
Get-Item $script:OutDir\foo.txt -ErrorAction SilentlyContinue | ForEach-Object Name | Should -BeExactly foo.txt
}
}

Context 'JSON manifest conditions' {
It 'Evaluates JSON content conditions that reference parameters' {
$script:PlasterManifestPath = "$TemplateDir\plasterManifest.json"

@'
{
"$schema": "https://raw.github.com/PowerShellOrg/Plaster/v2/schema/plaster-manifest-v2.json",
"schemaVersion": "2.0",
"metadata": {
"name": "TemplateName",
"id": "513d2fdc-3cce-47d9-9531-d85114efb224",
"version": "0.2.0",
"title": "Testing",
"description": "Manifest file for testing.",
"author": "Plaster",
"tags": [
"Test"
]
},
"parameters": [
{
"name": "Feature",
"type": "text",
"prompt": "Feature",
"default": "CopyFile"
}
],
"content": [
{
"type": "file",
"source": "Recurse\\foo.txt",
"destination": "foo.txt",
"condition": "${Feature} -eq 'CopyFile'"
}
]
}
'@ | Out-File $script:PlasterManifestPath -Encoding utf8

Invoke-Plaster -TemplatePath $TemplateDir -DestinationPath $script:OutDir -Feature CopyFile -NoLogo 6> $null

Get-Item $script:OutDir\foo.txt -ErrorAction SilentlyContinue | ForEach-Object Name | Should -BeExactly foo.txt
}

It 'Evaluates JSON parameter conditions that reference other parameters' {
$script:PlasterManifestPath = "$TemplateDir\plasterManifest.json"

@'
{
"$schema": "https://raw.github.com/PowerShellOrg/Plaster/v2/schema/plaster-manifest-v2.json",
"schemaVersion": "2.0",
"metadata": {
"name": "TemplateName",
"id": "513d2fdc-3cce-47d9-9531-d85114efb224",
"version": "0.2.0",
"title": "Testing",
"description": "Manifest file for testing.",
"author": "Plaster",
"tags": [
"Test"
]
},
"parameters": [
{
"name": "Primary",
"type": "text",
"prompt": "Primary",
"default": "EnableSecondary"
},
{
"name": "Secondary",
"type": "text",
"prompt": "Secondary",
"default": "CopyFile",
"condition": "${Primary} -eq 'EnableSecondary'"
}
],
"content": [
{
"type": "file",
"source": "Recurse\\foo.txt",
"destination": "foo.txt",
"condition": "${Secondary} -eq 'CopyFile'"
}
]
}
'@ | Out-File $script:PlasterManifestPath -Encoding utf8

Invoke-Plaster -TemplatePath $TemplateDir -DestinationPath $script:OutDir -Primary EnableSecondary -Secondary CopyFile -NoLogo 6> $null

Get-Item $script:OutDir\foo.txt -ErrorAction SilentlyContinue | ForEach-Object Name | Should -BeExactly foo.txt
}

It 'Evaluates JSON multichoice conditions that use parameter values' {
$script:PlasterManifestPath = "$TemplateDir\plasterManifest.json"

@'
{
"$schema": "https://raw.github.com/PowerShellOrg/Plaster/v2/schema/plaster-manifest-v2.json",
"schemaVersion": "2.0",
"metadata": {
"name": "TemplateName",
"id": "513d2fdc-3cce-47d9-9531-d85114efb224",
"version": "0.2.0",
"title": "Testing",
"description": "Manifest file for testing.",
"author": "Plaster",
"tags": [
"Test"
]
},
"parameters": [
{
"name": "Options",
"type": "multichoice",
"prompt": "Options",
"choices": [
{
"label": "&Git",
"value": "Git"
},
{
"label": "&None",
"value": "None"
}
]
}
],
"content": [
{
"type": "file",
"source": "Recurse\\foo.txt",
"destination": "foo.txt",
"condition": "${Options} -contains 'Git'"
}
]
}
'@ | Out-File $script:PlasterManifestPath -Encoding utf8

Invoke-Plaster -TemplatePath $TemplateDir -DestinationPath $script:OutDir -Options Git -NoLogo 6> $null

Get-Item $script:OutDir\foo.txt -ErrorAction SilentlyContinue | ForEach-Object Name | Should -BeExactly foo.txt
}
}
}
Loading