Skip to content

Set execute permission on scripts with shebangs#1467

Merged
eddelbuettel merged 1 commit intoRcppCore:masterfrom
ellert:consistency
Apr 1, 2026
Merged

Set execute permission on scripts with shebangs#1467
eddelbuettel merged 1 commit intoRcppCore:masterfrom
ellert:consistency

Conversation

@ellert
Copy link
Copy Markdown
Contributor

@ellert ellert commented Apr 1, 2026

  • Set execute permission on scripts with shebangs

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

@eddelbuettel
Copy link
Copy Markdown
Member

eddelbuettel commented Apr 1, 2026

We tend not do the bulk whitespace change commits as they obfuscate git glame and friends. Please take the two files inst/tinytest/cpp/*cpp out of the PR (as well as src/Makevars.win), I can then accept the (fairly meaningless for very old examples) chmod part. In other words just exclude whitespace only changes.

Copy link
Copy Markdown
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I am indifferent on the overall merit but it won't do harm.

@ellert ellert changed the title Line endings and permissions Set execute permission on scripts with shebangs Apr 1, 2026
Copy link
Copy Markdown
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RPM packaging complains about executables without shebang and shebangs without execution bit. So this just makes life downstream easier. :)

@eddelbuettel
Copy link
Copy Markdown
Member

I know, but it is still just a source property that has not bitten anyone in 15 years. Oh well. In it goes with dual approval.

@eddelbuettel eddelbuettel merged commit 6036853 into RcppCore:master Apr 1, 2026
12 checks passed
@ellert ellert deleted the consistency branch April 1, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants