Skip to content

ENH: Discrete and Continuous Controllers#946

Draft
Malmahrouqi3 wants to merge 3 commits intoRocketPy-Team:developfrom
Malmahrouqi3:enh/discrete_and_contrinuous_control
Draft

ENH: Discrete and Continuous Controllers#946
Malmahrouqi3 wants to merge 3 commits intoRocketPy-Team:developfrom
Malmahrouqi3:enh/discrete_and_contrinuous_control

Conversation

@Malmahrouqi3
Copy link
Copy Markdown
Member

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

#274

New behavior

Tested on the Airbrakes Example (docs/user/airbrakes.rst)

(Discrete 10 Hz sampling)
Apogee State
Apogee Time: 22.776 s
Apogee Altitude: 4302.839 m (ASL) | 2902.839 m (AGL)
Apogee Freestream Speed: 15.591 m/s
Apogee X position: -3.800 m
Apogee Y position: 465.700 m
Apogee latitude: 32.9944416°
Apogee longitude: -106.9750387°

Maximum altitude: 2902.84 m
Vertical velocity at apogee: -0.0000 m/s
(Discrete 100 Hz sampling)
Apogee State
Apogee Time: 22.777 s
Apogee Altitude: 4302.992 m (ASL) | 2902.992 m (AGL)
Apogee Freestream Speed: 15.592 m/s
Apogee X position: -3.802 m
Apogee Y position: 465.736 m
Apogee latitude: 32.9944419°
Apogee longitude: -106.9750388°

Maximum altitude: 2902.99 m
Vertical velocity at apogee: -0.0000 m/s
(Continuous inf sampling)
Apogee State
Apogee Time: 25.886 s
Apogee Altitude: 4705.476 m (ASL) | 3305.476 m (AGL)
Apogee Freestream Speed: 20.662 m/s
Apogee X position: -5.541 m
Apogee Y position: 588.778 m
Apogee latitude: 32.9955483°
Apogee longitude: -106.9750574°

Maximum altitude: 3305.48 m
Vertical velocity at apogee: -0.0000 m/s

Breaking change

  • Yes
  • No

Additional information

There is no node creation for continuous controllers hence this step is skipped in flight.py.

@Malmahrouqi3 Malmahrouqi3 self-assigned this Mar 30, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.02%. Comparing base (9cf3dd4) to head (31d80b9).
⚠️ Report is 49 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/rocket/rocket.py 25.00% 6 Missing ⚠️
rocketpy/simulation/flight.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #946      +/-   ##
===========================================
+ Coverage    80.27%   81.02%   +0.74%     
===========================================
  Files          104      107       +3     
  Lines        12769    13915    +1146     
===========================================
+ Hits         10250    11274    +1024     
- Misses        2519     2641     +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant