Skip to content

ENH: Update requirements and OpenRocket version#39

Merged
Gui-FernandesBR merged 9 commits intomasterfrom
general-update
Mar 29, 2026
Merged

ENH: Update requirements and OpenRocket version#39
Gui-FernandesBR merged 9 commits intomasterfrom
general-update

Conversation

@Gui-FernandesBR
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project’s OpenRocket integration by replacing orhelper with a custom JPype-based runtime and refreshes dependency/docs accordingly to support newer OpenRocket JARs.

Changes:

  • Introduces a new JPype-based OpenRocketSession runtime and logic to auto-select the newest OpenRocket*.jar.
  • Updates CLI and test harness to use the new runtime and pathlib.Path-based paths.
  • Updates dependencies (jpype1) and documentation for Java/OpenRocket download guidance.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/conftest.py Switches acceptance fixture setup to use OpenRocketSession, Path, and zip-extraction helpers.
test_ork2json-debugger.py Wraps debugger invocation in __main__ and calls Click command with args list.
rocketserializer/openrocket_runtime.py Adds new JPype-backed OpenRocket runtime, jar selection, and Java compatibility helpers.
rocketserializer/cli.py Replaces orhelper usage with OpenRocketSession and uses latest-jar selection when --ork_jar is omitted.
requirements.in Drops orhelper and adds jpype1<1.5.
README.md Updates Java/OpenRocket guidance and dependency list to match the new runtime.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Gui-FernandesBR Gui-FernandesBR merged commit d0861d1 into master Mar 29, 2026
5 checks passed
@Gui-FernandesBR Gui-FernandesBR linked an issue Mar 29, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH: upgrade openrocket version to v24

2 participants