ENH: Update requirements and OpenRocket version#39
Merged
Gui-FernandesBR merged 9 commits intomasterfrom Mar 29, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s OpenRocket integration by replacing orhelper with a custom JPype-based runtime and refreshes dependency/docs accordingly to support newer OpenRocket JARs.
Changes:
- Introduces a new JPype-based
OpenRocketSessionruntime and logic to auto-select the newestOpenRocket*.jar. - Updates CLI and test harness to use the new runtime and
pathlib.Path-based paths. - Updates dependencies (
jpype1) and documentation for Java/OpenRocket download guidance.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/conftest.py | Switches acceptance fixture setup to use OpenRocketSession, Path, and zip-extraction helpers. |
| test_ork2json-debugger.py | Wraps debugger invocation in __main__ and calls Click command with args list. |
| rocketserializer/openrocket_runtime.py | Adds new JPype-backed OpenRocket runtime, jar selection, and Java compatibility helpers. |
| rocketserializer/cli.py | Replaces orhelper usage with OpenRocketSession and uses latest-jar selection when --ork_jar is omitted. |
| requirements.in | Drops orhelper and adds jpype1<1.5. |
| README.md | Updates Java/OpenRocket guidance and dependency list to match the new runtime. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.