fix: simplify release to workflow_dispatch (no bot commits)#48
Merged
Wenxin-Jiang merged 4 commits intomainfrom Apr 2, 2026
Merged
fix: simplify release to workflow_dispatch (no bot commits)#48Wenxin-Jiang merged 4 commits intomainfrom
Wenxin-Jiang merged 4 commits intomainfrom
Conversation
Replace the two-workflow PR-based release flow with a single workflow_dispatch trigger, matching the socket-cli pattern. Changes: - Remove release-prep.yml (automated version bump + PR creation) - Make release.yml a manual workflow_dispatch that reads the version from Cargo.toml, tags, builds, and publishes - Add dry-run option to build without publishing - Use NPM_TOKEN secret for npm publish (fixes ENEEDAUTH on new packages) - Add registry-url to setup-node for proper auth Release flow after this change: 1. Bump version in a PR: run scripts/version-sync.sh, commit, merge 2. Click "Run workflow" on Release 3. Done - tags, builds, and publishes automatically This avoids the signed commit requirement that blocked github-actions[bot] from pushing to protected branches. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The original ENEEDAUTH failure was caused by missing registry-url in setup-node, not missing NPM_TOKEN. With registry-url set, OIDC trusted publishing works for both existing and new packages. Also fixes zizmor secrets-outside-env warnings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
OIDC trusted publishing doesn't work for brand new packages that don't exist on the npm registry yet. The new -gnu/-musl packages need NPM_TOKEN for their first publish. Added `environment: npm-publish` to satisfy zizmor's secrets-outside-env audit. The environment needs to be created in the repo settings with the NPM_TOKEN secret. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove NPM_TOKEN and environment — use the same OIDC pattern as socket-cli and socket-mcp. The registry-url in setup-node enables the OIDC token exchange. Note: new packages that don't exist on npm yet must be pre-created manually before the first publish. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
marvinsocket
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-prep.yml(automated version bump + PR creation that failed due to signed commit requirements)release.ymlto a singleworkflow_dispatchtrigger that reads the version fromCargo.tomldry-runoption to build without publishingNPM_TOKENsecret for npm publish (fixesENEEDAUTHon new packages that don't support OIDC yet)registry-urltosetup-nodefor proper npm authThis follows the same pattern as socket-cli.
Release flow after this change
scripts/version-sync.sh <version>, commit, merge tomainWhy
The previous approach required
github-actions[bot]to push commits to protected branches, which was blocked by:Prerequisites
NPM_TOKENsecret to the repo (automation token from npmjs.com@socketsecurityorg)Supersedes #47
🤖 Generated with Claude Code