Skip to content

[pre-commit.ci] pre-commit autoupdate#14325

Merged
cclauss merged 8 commits intomasterfrom
pre-commit-ci-update-config
Apr 2, 2026
Merged

[pre-commit.ci] pre-commit autoupdate#14325
cclauss merged 8 commits intomasterfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci
Copy link
Copy Markdown
Contributor

@pre-commit-ci pre-commit-ci bot commented Mar 2, 2026

updates:

Also configures mypy to explicitly target Python 3.14 by adding [tool.mypy] with python_version = "3.14" to pyproject.toml, matching the project's requires-python = ">=3.14" requirement.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.14.14 → v0.15.4](astral-sh/ruff-pre-commit@v0.14.14...v0.15.4)
- [github.com/tox-dev/pyproject-fmt: v2.12.1 → v2.16.2](tox-dev/pyproject-fmt@v2.12.1...v2.16.2)
- [github.com/abravalheri/validate-pyproject: v0.24.1 → v0.25](abravalheri/validate-pyproject@v0.24.1...v0.25)
@pre-commit-ci pre-commit-ci bot requested a review from cclauss as a code owner March 2, 2026 18:27
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Mar 2, 2026
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Mar 9, 2026
@cclauss
Copy link
Copy Markdown
Member

cclauss commented Mar 9, 2026

Mypy thinks we are not running on Python 3.14 but this repo ALWAYS runs on the most current version of CPython.

@cclauss
Copy link
Copy Markdown
Member

cclauss commented Apr 1, 2026

pre-commit.ci run

@cclauss
Copy link
Copy Markdown
Member

cclauss commented Apr 1, 2026

@copilot How should we fix?

Should we upgrade from mypy to ty or pyrefly? Does ty still not work in pre-commit?

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 1, 2026

@copilot How should we fix?

Should we upgrade from mypy to ty or pyrefly? Does ty still not work in pre-commit?

The simplest fix is to configure mypy to explicitly target Python 3.14, which I've done in commit cfe314e:

  • Added [tool.mypy] section to pyproject.toml with python_version = "3.14" — without this, mypy uses the runtime Python version rather than the project's target version
  • Updated the mypy pre-commit hook from v1.19.1 to v1.20.0 (latest)

Regarding ty and pyrefly: both are very new and not yet mature enough to replace mypy in CI for a large codebase like this. ty (Astral) does have a pre-commit hook at https://github.com/astral-sh/ty, but it's still alpha. Switching would be worth revisiting once either project reaches a stable 1.0 release.

Mypy thinks we are not running on Python 3.14 but this repo ALWAYS runs on the most current version of CPython.

Fixed in commit cfe314e — added [tool.mypy] with python_version = "3.14" to pyproject.toml so mypy now targets Python 3.14, matching requires-python = ">=3.14".

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/python/mypy/releases
    • Triggering command: /usr/bin/curl curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

@cclauss
Copy link
Copy Markdown
Member

cclauss commented Apr 1, 2026

pre-commit.ci autofix

@cclauss
Copy link
Copy Markdown
Member

cclauss commented Apr 1, 2026

pre-commit.ci autofix

@cclauss
Copy link
Copy Markdown
Member

cclauss commented Apr 1, 2026

pre-commit.ci run

@cclauss cclauss enabled auto-merge (squash) April 1, 2026 23:41
@cclauss
Copy link
Copy Markdown
Member

cclauss commented Apr 1, 2026

@copilot Please create a new pull request to fix this?

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 1, 2026

@cclauss I've opened a new pull request, #14496, to work on those changes. Once the pull request is ready, I'll request review from you.

Comment out mypy configuration in pre-commit file
@cclauss cclauss merged commit 840ca00 into master Apr 2, 2026
7 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Apr 2, 2026
@cclauss cclauss deleted the pre-commit-ci-update-config branch April 2, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants