[FLINK-39018][checkpoint] Support checkpoint for LocalInputChannel#27861
Open
1996fanrui wants to merge 5 commits intoapache:masterfrom
Open
[FLINK-39018][checkpoint] Support checkpoint for LocalInputChannel#278611996fanrui wants to merge 5 commits intoapache:masterfrom
1996fanrui wants to merge 5 commits intoapache:masterfrom
Conversation
Collaborator
1996fanrui
force-pushed
the
39018/support-checkpoint-for-localinputchannel
branch
from
cf606db to
4fa25ef
Compare
…de toBeConsumedBuffers
…ot for recovered buffers
…r availability for recovered buffers
…n if it is blocked to ensure the checkpoint barrier can be handled by downstream task
1996fanrui
force-pushed
the
39018/support-checkpoint-for-localinputchannel
branch
from
4fa25ef to
b1a7ca7
Compare
… physical channels
pnowojski
reviewed
Apr 1, 2026
|
|
||
| if (!toBeConsumedBuffers.isEmpty()) { | ||
| return getBufferAndAvailability(toBeConsumedBuffers.removeFirst()); | ||
| // If there is a pending priority event (e.g., unaligned checkpoint barrier), fetch it |
Contributor
There was a problem hiding this comment.
I think this method has grown too much and should be split into smaller ones
Comment on lines
+460
to
+462
| // When blocked, only allow priority buffers (e.g. unaligned checkpoint barriers) | ||
| // to be polled. Data buffers remain blocked until resumeConsumption() is called. | ||
| if (isBlocked && buffers.getNumPriorityElements() == 0) { |
Contributor
There was a problem hiding this comment.
Why do we need this change from this commit? Could you elaborate a bit more in the commit message?
Comment on lines
+552
to
+558
| // Block the subpartition by consuming an aligned checkpoint barrier | ||
| blockSubpartitionByCheckpoint(1); | ||
| assertThat(availablityListener.getNumPriorityEvents()).isZero(); | ||
|
|
||
| // While blocked, add an unaligned checkpoint barrier (priority event). | ||
| // Even though isBlocked=true, the priority event notification should NOT | ||
| // be suppressed — priority events must bypass blocking. |
Contributor
There was a problem hiding this comment.
How can this happen in reality outside of the unit test? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #27782 and #27783
What is the purpose of the change
[FLINK-39018][checkpoint] Support checkpoint for LocalInputChannel
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation