[Bug] Fix TOCTOU race condition in MQClientInstance.brokerVersionTable access#10235
Open
Senrian wants to merge 1 commit intoapache:developfrom
Open
[Bug] Fix TOCTOU race condition in MQClientInstance.brokerVersionTable access#10235Senrian wants to merge 1 commit intoapache:developfrom
Senrian wants to merge 1 commit intoapache:developfrom
Conversation
Issue: apache#10214 Replace non-atomic check-then-act pattern with thread-safe operations: - sendHeartbeatToBroker(): use computeIfAbsent instead of containsKey+put - sendHeartbeatToBrokerV2(): same fix - findBrokerVersion(): use local variable to avoid NPE if entry removed between calls
Contributor
|
@Senrian This change is not recommended as it may cause performance issues. Please refer to the documentation:https://juejin.cn/post/7094561581631012878 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
Issue: #10214
In
MQClientInstance.java,brokerVersionTable(aConcurrentHashMap) is accessed using a non-atomic check-then-act pattern that can cause NullPointerException under concurrent access.Locations Fixed
Fix Pattern
Use
computeIfAbsentfor atomic get-or-create:For findBrokerVersion(), use a local variable to avoid NPE if entry is removed between calls.