WW-5326 Upgrade OGNL from 3.4.10 to 3.5.0-BETA4 and introduce StrutsContext#1654
Draft
lukaszlenart wants to merge 9 commits intomainfrom
Draft
WW-5326 Upgrade OGNL from 3.4.10 to 3.5.0-BETA4 and introduce StrutsContext#1654lukaszlenart wants to merge 9 commits intomainfrom
lukaszlenart wants to merge 9 commits intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…utsContext> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…h StrutsContext Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… StrutsContext construction Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…sContext Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tiles accessors are called by OGNL internal machinery with raw OgnlContext, not within a Struts evaluation context, so they cannot use StrutsContext. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WW-5326
Upgrades Apache Struts from OGNL 3.4.10 to 3.5.0-BETA4 and introduces
StrutsContext extends OgnlContext<StrutsContext>as the framework's own OGNL evaluation context. This lays the foundation for treating OGNL as an execution sandbox with typed, Struts-specific context state.Changes
OgnlContext<StrutsContext>— Struts' own OGNL context<StrutsContext>(~22 classes in core)Ognl.createDefaultContext()with directnew StrutsContext(...)inOgnlUtil,OgnlValueStackOgnlContextwith@SuppressWarnings("rawtypes")since OGNL internally creates rawOgnlContextwhen callingOgnl.getValue()Design decisions
Ognl.withBuilderProvider(): Gives Struts full ownership of context lifecycle, avoids global-state issuesOgnl.getValue()creates rawOgnlContext, notStrutsContext, so tiles must use raw typesReflectionContextStatemap entries to typedStrutsContextfields is Phase 2Test plan
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com