Open
Conversation
victormlg
force-pushed
the
spawn-validation
branch
from
9ff6382 to
0d54ac7
Compare
Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
spawn-validation
branch
from
0d54ac7 to
a226367
Compare
olehermanse
requested changes
Apr 1, 2026
Member
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
It's a bit hard to follow the code without seeing the bigger picture, please add:
--validateoption which validates the config and won't spawn in the future when that is implemented.- Some shell tests which use the
--validateoption and prove that it's passing and failing in the right situations. - Some explanation and examples for the feature in the README. Clearly mark it as work in progress.
Signed-off-by: Victor Moene <victor.moene@northern.tech>
olehermanse
reviewed
Apr 2, 2026
| ```yaml | ||
| templates: | ||
| ubuntu: | ||
| count: 1 |
Member
There was a problem hiding this comment.
count should be moved to group, not be in template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.