Refactored lint.py and other improvements#44
Draft
olehermanse wants to merge 23 commits intocfengine:mainfrom
Draft
Refactored lint.py and other improvements#44olehermanse wants to merge 23 commits intocfengine:mainfrom
olehermanse wants to merge 23 commits intocfengine:mainfrom
Conversation
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
…ability Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
We want to insert newlines before promise types (promise guards). So we need a test for this. Will fix the implementation in a subsequent commit. Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
We want to ensure empty newlines are added before each class guard (except the first one in each bundle section). Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
The formatter now: - Removes empty leading / trailing comments. - Inserts empty lines before each class guard except the first one. - Inserts empty lines before each promise guard except the first one. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
…tate The user_definitions code for detecting namespace, unknown bundles, etc. did not work previously when you gave a filename as an argument. It was only working for folders. This commit fixes that, by refactoring the code and making the handling of args vs files vs folders more clear and consistent. Need to make the entry point functions create state, and then never be called recursively. I'm making state global now to make the refactoring easier, but can revert that later. I will do further refactoring commits after this one, but at this point I have something working, which passes tests, and fixes a bug. Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
olehermanse
force-pushed
the
refactoring
branch
2 times, most recently
from
bb35572 to
3b9f4d3
Compare
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on: #43