fix(textinput): slicing outside cap#532
Merged
bashbunni merged 3 commits intocharmbracelet:masterfrom Dec 5, 2024
MikaelFangel:fix-textinput
Merged
fix(textinput): slicing outside cap#532bashbunni merged 3 commits intocharmbracelet:masterfrom MikaelFangel:fix-textinput
bashbunni merged 3 commits intocharmbracelet:masterfrom
MikaelFangel:fix-textinput
Conversation
caarlos0
changed the title
caarlos0
approved these changes
Aug 13, 2024
Contributor
Author
|
Sure, I've added a test now that fails without the fix applied. |
Contributor
Author
|
@caarlos0 - Do I need to do anything else before it can be merged? 😄 |
Contributor
|
@MikaelFangel thank you so much for identifying this and fixing it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #531
Fixes: charmbracelet/gum#591
Changes
pwith the size of theWidth + 1because when you usevar()to assign, the cap defaults to 32 and thus it is possible to get out of bounds errors.