feat(textarea): expose MoveToBegin and MoveToEnd methods#809
Merged
aymanbagabas merged 1 commit intov2-expfrom Jul 10, 2025
Merged
feat(textarea): expose MoveToBegin and MoveToEnd methods#809aymanbagabas merged 1 commit intov2-expfrom
aymanbagabas merged 1 commit intov2-expfrom
Conversation
This commit exposes the MoveToBegin and MoveToEnd methods in the textarea package, allowing users to programmatically move the cursor to the beginning or end of the input text.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes two new public methods (MoveToBegin and MoveToEnd) on the Model to allow programmatic cursor movement, and updates internal calls to use these methods.
- Renames
moveToBegin→MoveToBeginandmoveToEnd→MoveToEndand updates their comments. - Updates all internal invocations in
Updateto use the new exported methods.
Comments suppressed due to low confidence (2)
textarea/textarea.go:986
- There aren’t any unit tests covering the newly exported
MoveToBeginandMoveToEndmethods. Adding tests will ensure correct behavior and prevent regressions.
// MoveToBegin moves the cursor to the beginning of the input.
textarea/textarea.go:994
- If
m.valuecan ever be empty,len(m.value)-1will underflow, settingm.rowto -1. Consider guarding against an empty value slice before setting the row.
m.row = len(m.value) - 1
raphamorim
approved these changes
Jul 9, 2025
andreynering
approved these changes
Jul 9, 2025
kujtimiihoxha
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit exposes the MoveToBegin and MoveToEnd methods in the textarea package, allowing users to programmatically move the cursor to the beginning or end of the input text.