First bit of Tektronix support, also SGR 53/55 (overline)#23
Open
rbanffy wants to merge 3 commits intocharmbracelet:mainfrom
Open
First bit of Tektronix support, also SGR 53/55 (overline)#23rbanffy wants to merge 3 commits intocharmbracelet:mainfrom
rbanffy wants to merge 3 commits intocharmbracelet:mainfrom
Conversation
aymanbagabas
approved these changes
Nov 21, 2024
Comment on lines
+92
to
+95
| case 53: | ||
| str += "Overline" | ||
| case 55: | ||
| str += "No overline" |
Member
There was a problem hiding this comment.
These are not widely supported :/
Author
There was a problem hiding this comment.
It's a sad thing. On the bright side, iTerm and VTE (and Konsole, and a couple others) do. Very handy for status lines.
Member
There was a problem hiding this comment.
Even if they're not widely supported I can see them being useful, both from a completeness standpoint and for the sake of simply understanding what they are.
Member
There was a problem hiding this comment.
@rbanffy It would be really helpful to implement these SGR arguments in x/ansi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a very initial support for VT-style Tektronix graphics ("CSI ?38h: Enable private mode "tektronix mode") and overline attribute support (I was learning my way around the code). Not sure how to add unit tests for those, however - might need help there