Skip to content

chore: Update CODEOWNERS for pnpm/uv migration#374

Merged
kodiakhq[bot] merged 2 commits intomainfrom
chore/update-codeowners-pnpm-uv
Apr 2, 2026
Merged

chore: Update CODEOWNERS for pnpm/uv migration#374
kodiakhq[bot] merged 2 commits intomainfrom
chore/update-codeowners-pnpm-uv

Conversation

@erezrokah
Copy link
Copy Markdown
Member

Update CODEOWNERS to reference pnpm-lock.yaml instead of package-lock.json.

Copilot AI review requested due to automatic review settings April 1, 2026 13:24
@erezrokah erezrokah requested a review from a team as a code owner April 1, 2026 13:24
@erezrokah erezrokah requested review from disq and removed request for a team April 1, 2026 13:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates repository ownership configuration to reflect the migration from npm to pnpm by changing the lockfile referenced in CODEOWNERS.

Changes:

  • Replace package-lock.json with pnpm-lock.yaml in CODEOWNERS.
  • Touch related file patterns in CODEOWNERS (no functional code changes).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +3 to +6
pnpm-lock.yaml
package.json
.release-please-manifest.json
CHANGELOG.md
CHANGELOG.md No newline at end of file
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODEOWNERS entries must include at least one owner after the path pattern. As written, pnpm-lock.yaml (and the following file patterns) have no owners, so GitHub will ignore these lines. Either append the intended owner (e.g., @cloudquery/backend) to each entry or remove the redundant lines since * @cloudquery/backend already covers all files.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong, no owner means anymore can review

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong, no owner means anymore can review

@erezrokah erezrokah added the automerge Add to automerge PRs once requirements are met label Apr 1, 2026
@kodiakhq kodiakhq bot merged commit 6876b61 into main Apr 2, 2026
9 checks passed
@kodiakhq kodiakhq bot deleted the chore/update-codeowners-pnpm-uv branch April 2, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Add to automerge PRs once requirements are met

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants