Skip to content

fix: Rename docker registry host #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erezrokah merged 2 commits into from
Jan 3, 2024
Merged

fix: Rename docker registry host #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6da782
fix: Rename docker registry host
erezrokah Jan 3, 2024
b2e5a89
Update plugin.py
erezrokah Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cloudquery/sdk/serve/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ def run_docker_cmd(cmd, plugin_dir):
raise ChildProcessError("Unable to run Docker command: %s" % err)

def build_target(target: plugin.plugin.BuildTarget):
image_repository = "registry.cloudquery.io/%s/%s-%s" % (
image_repository = "docker.cloudquery.io/%s/%s-%s" % (
self._plugin.team(),
self._plugin.kind(),
self._plugin.name(),
Expand Down
4 changes: 2 additions & 2 deletions tests/serve/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def test_plugin_package():
)
assert (
package["supported_targets"][0]["docker_image_tag"]
== "registry.cloudquery.io/cloudquery/source-memdb:v1.0.0-linux-amd64"
== "docker.cloudquery.io/cloudquery/source-memdb:v1.0.0-linux-amd64"
)
assert package["supported_targets"][1]["os"] == "linux"
assert package["supported_targets"][1]["arch"] == "arm64"
Expand All @@ -201,5 +201,5 @@ def test_plugin_package():
)
assert (
package["supported_targets"][1]["docker_image_tag"]
== "registry.cloudquery.io/cloudquery/source-memdb:v1.0.0-linux-arm64"
== "docker.cloudquery.io/cloudquery/source-memdb:v1.0.0-linux-arm64"
)