feat: Add handling of error messages to sdk#2195
Merged
Conversation
| return scheduler | ||
| } | ||
|
|
||
| func (d *Scheduler) Sync(ctx context.Context, tableClients []WorkUnit, resolvedResources chan<- *schema.Resource) { |
Member
There was a problem hiding this comment.
Why do some schedulers take this new channel as a param while others have it on the scheduler client struct directly?
Member
There was a problem hiding this comment.
Maybe we should only have it on the struct for simplicity?
Author
There was a problem hiding this comment.
Yeah you are completely right I've removed it from func param
Author
There was a problem hiding this comment.
Or maybe I have to do it differently because I have to pass it down from syncClient
przste-go
force-pushed
the
feature/eng-1505-explore-possibility-of-replacing-otel-with-cli-progress
branch
from
f4ebb98 to
3deba3f
Compare
added 3 commits
June 26, 2025 13:02
Comment on lines
+263
to
+265
| if !req.WithErrorMessages { | ||
| continue | ||
| } |
Member
There was a problem hiding this comment.
This will be removed in the future
murarustefaan
approved these changes
Jun 27, 2025
przste-go
deleted the
feature/eng-1505-explore-possibility-of-replacing-otel-with-cli-progress
branch
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
🤖 I have created a release *beep* *boop* --- ## [4.85.0](v4.84.2...v4.85.0) (2025-06-27) ### Features * Add handling of error messages to sdk ([#2195](#2195)) ([c5273da](c5273da)) ### Bug Fixes * **deps:** Update aws-sdk-go-v2 monorepo ([#2193](#2193)) ([d220f63](d220f63)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.26.13 ([#2196](#2196)) ([140b6f3](140b6f3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/plugin-sdk-python
that referenced
this pull request
Sep 3, 2025
Fixes cloudquery/cloudquery#15525, the Python equivalent of cloudquery/plugin-sdk#2195 Most of the changes are actually to the MemDB plugin ~~(that's why tests are failing, PR in draft while I fix those)~~, as I turned it into a "real" plugin that uses the SDK scheduler so I can test this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR requires changes to plugin-pb
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)