refactor(models): add default value for outputDir#358
Merged
Conversation
Tlacenka
reviewed
Dec 13, 2023
github-actions
bot
added
🦾 CI/CD
BioPhoton
commented
Dec 17, 2023
matejchalk
requested changes
Dec 17, 2023
Collaborator
matejchalk
left a comment
matejchalk
left a comment
There was a problem hiding this comment.
Thanks for the explanations. The persist config handling now looks good 👍 But the same strategy cannot apply to the upload config, as described in comments.
packages/cli/src/lib/print-config/print-config-command.unit.test.ts
Outdated
Show resolved
Hide resolved
…st.ts Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
matejchalk
requested changes
Dec 18, 2023
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
matejchalk
approved these changes
Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to reduce the scope as much as possible. In addition I added comments in code and here to understand the changes better and have and easier review process. Hopefully this makes up the messy change.
This PR includes:
(formats follow in fix(cli): fix json format handling #360 )
Resources:
Overview of the target architecture can be found here: https://github.com/code-pushup/cli/wiki/Research:-Module-architecture-and-responsibilities
closes #321