refactor(cli): adopt core-config middleware logic#416
Merged
Conversation
matejchalk
requested changes
Jan 16, 2024
BioPhoton
commented
Jan 16, 2024
BioPhoton
changed the title
matejchalk
reviewed
Jan 17, 2024
Collaborator
matejchalk
left a comment
matejchalk
left a comment
There was a problem hiding this comment.
Overall looks good 👍
There are some interesting tests here, though. Maybe @Tlacenka could take a look?
packages/cli/src/lib/implementation/global.utils.integration.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
matejchalk
previously approved these changes
Jan 17, 2024
Tlacenka
suggested changes
Jan 17, 2024
Collaborator
Tlacenka
left a comment
Tlacenka
left a comment
There was a problem hiding this comment.
I looked at both the test code and the way the tests are structured.
It would be great to keep focusing on test readability introduced in the test strategy.
I added some tips on how to improve that below. If you have any questions, let me know and we can go through it together.
packages/cli/src/lib/implementation/global.utils.integration.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/implementation/core-config.middleware.integration.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/implementation/core-config.middleware.integration.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/implementation/core-config.middleware.integration.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/implementation/core-config.middleware.integration.test.ts
Show resolved
Hide resolved
Tlacenka
reviewed
Jan 18, 2024
packages/cli/src/lib/implementation/core-config.middleware.integration.test.ts
Outdated
Show resolved
Hide resolved
Tlacenka
reviewed
Jan 25, 2024
BioPhoton
commented
Jan 25, 2024
packages/cli/src/lib/implementation/core-config.options-and-middleware.integration.test.ts
Outdated
Show resolved
Hide resolved
Tlacenka
approved these changes
Jan 25, 2024
Collaborator
Tlacenka
left a comment
Tlacenka
left a comment
There was a problem hiding this comment.
Nice test improvements, the readCodePushupConfig mock is better 😁
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #361