test(examples-plugins): convert integration tests to e2e#512
test(examples-plugins): convert integration tests to e2e#512
Conversation
Tlacenka
left a comment
There was a problem hiding this comment.
Good effort!
Unfortunately, the tests don't work for me. Do they work as expected when you run them locally?
examples/plugins/src/lighthouse/src/lighthouse.plugin.e2e.test.ts
Outdated
Show resolved
Hide resolved
examples/plugins/src/lighthouse/src/lighthouse.plugin.e2e.test.ts
Outdated
Show resolved
Hide resolved
examples/plugins/src/lighthouse/src/lighthouse.plugin.e2e.test.ts
Outdated
Show resolved
Hide resolved
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 46c5e89. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
Tlacenka
left a comment
There was a problem hiding this comment.
This seems like the tests live in E2E folder but they are not E2E tests.
They also now require all E2E tests to run sequentially.
As this is an example plugin and not an official one, the cons outweigh the pros for me. So I am leaning towards skipping/removing the tests until such time when the lighthouse functionality can be executed via CLI and become a proper E2E test.
# Conflicts: # packages/utils/src/lib/git.ts
examples/plugins/src/lighthouse/src/lighthouse.plugin.integration.test.ts
Outdated
Show resolved
Hide resolved
examples/plugins/src/lighthouse/src/lighthouse.plugin.integration.test.ts
Outdated
Show resolved
Hide resolved
…ion.test.ts Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
…ion.test.ts Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
I did not change the logic of the example plugin but moved the long running tests to e2e.
I think we should put our time in the official lighthouse plugin.
closes #490
followed by #488