Open
Conversation
Contributor
|
The change will make ruby-binlog FlyData specific, which we should avoid. Can you come up with a different way? |
Author
|
Not really. It does add a path for /opt/flydata but the original paths are still there. This is only so we can compile our ruby-binlog. This is due to flydata-mysql-replication-listener package now puts the boost headers and libs in /opt/flydata. Reasoning is that although the boost libs are renamed, the headers aren't renamed and can conflict with original system boost packages and it is best to avoid this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add /opt/flydata paths to prepare for installation of flydata-mysql-replication-listener package. This should default to normal if it doesn't find it in /opt/flydata.