fix: clean up upgrade output and hide empty table headers#459
Merged
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Clean up the ugly `cli upgrade` output and fix a systemic issue with empty header rows in box-drawing tables across the codebase. ## Upgrade output Before: ``` Binary: Installed to /home/byk/.local/bin/sentry ✓ Upgraded to 0.18.0-dev.1773836960 0.18.0-dev.1773794950 → 0.18.0-dev.1773836960 ╭─────────┬─────────╮ │ │ │ ├─────────┼─────────┤ │ Method │ curl │ │ Channel │ nightly │ ╰─────────┴─────────╯ ``` After: ``` ✓ Upgraded to 0.18.0-dev.1773836960 (from 0.18.0-dev.1773794950) Method: curl · Channel: nightly ``` Changes: - Replace metadata table with a compact muted inline line - Remove redundant version arrow; fold "from" version into success line - Add `--quiet` to `cli setup` subprocess to suppress leaked stdout ## Systemic table fix `mdKvTable()` without a heading produces `| | |` empty header cells, which rendered as an ugly empty bordered row in box-drawing tables. This affected 12 call sites: auth status, issue/org/project details, trace/span/log views, and more. Fix: add `hideHeaders` option to `renderTextTable` and auto-detect all-empty headers in `renderTableToken` to skip the header row while still using it for column width measurement.
53be35d to
d41b0bd
Compare
Contributor
Codecov Results 📊✅ 116 passed | Total: 116 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1147 uncovered lines. Files with missing lines (2)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.21% 95.21% —%
==========================================
Files 176 176 —
Lines 23930 23934 +4
Branches 0 0 —
==========================================
+ Hits 22783 22787 +4
- Misses 1147 1147 —
- Partials 0 0 —Generated by Codecov Action |
BYK
commented
Mar 18, 2026
Per review feedback, the empty-header detection logic now lives in renderTextTable itself (auto-detects when all headers are empty/whitespace) rather than requiring each caller to detect and pass hideHeaders. renderTableToken in markdown.ts no longer needs special handling — renderTextTable handles it transparently.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
The destructuring default only fires when the property is undefined, making the options.hideHeaders ?? fallback redundant inside it. Extract to a separate const with ?? so explicit false from callers is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Clean up the ugly
cli upgradeoutput and fix a systemic issue withempty header rows in box-drawing tables across the codebase.
Upgrade output
Before:
After:
Changes:
--quiettocli setupsubprocess to suppress leaked stdoutSystemic table fix
mdKvTable()without a heading produces| | |empty header cells,which rendered as an ugly empty bordered row in box-drawing tables.
This affected 12 call sites: auth status, issue/org/project details,
trace/span/log views, and more.
Fix: add
hideHeadersoption torenderTextTableand auto-detectall-empty headers in
renderTableTokento skip the header row whilestill using it for column width measurement.