fix(event-view): auto-redirect issue short IDs in two-arg form (CLI-MP)#558
Merged
fix(event-view): auto-redirect issue short IDs in two-arg form (CLI-MP)#558
Conversation
When a user passes an issue short ID as the first of two positional args (e.g., `sentry event view JAVASCRIPT-NUXT-52 <event-id>`), the two-arg path in `parsePositionalArgs` treated it as a project slug, which always failed because issue short IDs are uppercase while project slugs are lowercase, and they include the issue number suffix. The one-arg path already handled this correctly via `looksLikeIssueShortId` detection, but the two-arg path only set a suggestion warning without changing the control flow. Fix: when `looksLikeIssueShortId(first)` is true in the two-arg path, set `issueShortId` and redirect to the issue's latest event (matching the one-arg behavior). The second argument is ignored with a warning. Fixes CLI-MP
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Coverage
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 126 passed | Total: 126 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1277 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.32% 95.33% +0.01%
==========================================
Files 194 194 —
Lines 27300 27343 +43
Branches 0 0 —
==========================================
+ Hits 26023 26066 +43
- Misses 1277 1277 —
- Partials 0 0 —Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
The `suggestion` field was the only code path setting it (the two-arg issue-short-ID branch), which was replaced with the `issueShortId` redirect. No remaining return path in `parsePositionalArgs` or `parseSingleArg` sets `suggestion`, so the type field, destructuring, and conditional log were all unreachable dead code. Addresses Cursor BugBot review comment.
Member
Author
|
Addressed Cursor BugBot's review comment about the dead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user passes an issue short ID as the first of two positional args
(e.g.,
sentry event view JAVASCRIPT-NUXT-52 <event-id>), the two-argpath in
parsePositionalArgstreated it as a project slug, which alwaysfailed because issue short IDs are uppercase while project slugs are
lowercase, and they include the issue number suffix.
The one-arg path already handled this correctly via
looksLikeIssueShortIddetection, but the two-arg path only set a suggestion warning without
changing the control flow.
Fix: when
looksLikeIssueShortId(first)is true in the two-arg path,set
issueShortIdand redirect to the issue's latest event (matchingthe one-arg behavior). The second argument is ignored with a warning.
Fixes CLI-MP