fix(dashboard): resolve dashboard by ID/slug in addition to title#559
Merged
fix(dashboard): resolve dashboard by ID/slug in addition to title#559
Conversation
Fixes CLI-MK resolveDashboardId() only matched non-numeric references against dashboard titles. Sentry's built-in dashboard has id "default-overview" but title "General", so `sentry dashboard view default-overview` threw a ValidationError despite listing the dashboard as available. Now matches against d.id first, then falls back to d.title. Also improves the error message to label the ID/Title columns and says "matching" instead of "with title".
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Coverage
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 126 passed | Total: 126 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1277 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.32% 95.32% —%
==========================================
Files 194 194 —
Lines 27300 27302 +2
Branches 0 0 —
==========================================
+ Hits 26023 26025 +2
- Misses 1277 1277 —
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CLI-MK
resolveDashboardId()only matched non-numeric references against dashboardtitles. Sentry's built-in dashboard has
id: "default-overview"buttitle: "General", sosentry dashboard view default-overviewthrew aValidationErrordespite listing the dashboard as available in the error.Changes
resolveDashboardId()now triesd.idbeforefalling back to
d.title(both case-insensitive). ID match takes prioritywhen a value collides with a different dashboard's title.
labels the available list columns as
(ID Title).priority, title fallback, and improved error wording.