refactor(event): deduplicate span tree building into shared helper#581
Merged
refactor(event): deduplicate span tree building into shared helper#581
Conversation
Extract buildEventViewData() that handles span tree fetch + trace assembly in one place. Previously this logic was duplicated across: 1. fetchLatestEventData (issue URL path) 2. fetchSpecificEventData (SHORT-ID/EVENT-ID path) 3. func() inline (normal event view path) The inline path also had a subtle difference: it used spanTreeResult.spans without ?? [] and omitted the && traceId guard. Now all paths use the same consistent logic. Addresses #574 (comment)
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Dashboard
Init
Other
Bug Fixes 🐛Dashboard
Event
Other
Internal Changes 🔧Coverage
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 126 passed | Total: 126 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1276 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 95.46% 95.45% -0.01%
==========================================
Files 194 194 —
Lines 28040 28036 -4
Branches 0 0 —
==========================================
+ Hits 26766 26760 -6
- Misses 1274 1276 +2
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #574 addressing Bugbot feedback about duplicated span tree building logic.
The span tree assembly (fetch spans → build trace object → assemble
EventViewData) was duplicated across three locations that could diverge over time:fetchLatestEventData— issue URL pathfetchSpecificEventData— SHORT-ID/EVENT-ID pathfunc()inline — normal event view pathThe inline path also had a subtle inconsistency: it used
spanTreeResult.spanswithout?? []and omitted the&& traceIdguard that the other two paths had.Fix
Extracted
buildEventViewData(org, event, spans)as a shared helper. All three paths now use it:fetchLatestEventData→ callsgetLatestEvent()thenbuildEventViewData()getEvent()thenbuildEventViewData()func()inline → callsfetchEventWithContext()thenbuildEventViewData()fetchSpecificEventDatais removed entirely (net -22 lines).Changes
src/commands/event/view.ts: AddedbuildEventViewData, removedfetchSpecificEventData, updated all three call sites