refactor(event): replace "latest" magic string with @latest sentinel constant#583
Merged
refactor(event): replace "latest" magic string with @latest sentinel constant#583
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Dashboard
Init
Other
Bug Fixes 🐛Dashboard
Event
Other
Internal Changes 🔧Coverage
Event
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 126 passed | Total: 126 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1270 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.47% 95.47% —%
==========================================
Files 194 194 —
Lines 28036 28037 +1
Branches 0 0 —
==========================================
+ Hits 26766 26767 +1
- Misses 1270 1270 —
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #574 — the bare string
"latest"was used as a sentineleventIdvalue across 4 assignment sites and 1 comparison with no named constant.Replaced with
LATEST_EVENT_SENTINEL = "@latest", using the@-prefix convention established byIssueSelectormagic selectors (@latest,@most_frequent) inarg-parsing.ts.Changes
src/commands/event/view.ts: AddedLATEST_EVENT_SENTINELconstant, replaced all 5 occurrences + updated commenttest/commands/event/view.test.ts: Updated 8 assertions to expect"@latest"