Skip to content

fix: 2 bug fixes — subcommand crash, negative span depth, pagination JSON parse #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 5 commits into from
Mar 30, 2026
Merged

fix: 2 bug fixes — subcommand crash, negative span depth, pagination JSON parse #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b66c283
fix(list-command): handle missing generated files in subcommand inter…
cursoragent Mar 30, 2026
2e7146f
fix(arg-parsing): reject negative values in parseSpanDepth
cursoragent Mar 30, 2026
db53c78
fix(pagination): handle corrupted cursor_stack JSON gracefully
cursoragent Mar 30, 2026
5f9207f
revert: remove try-catch from getSubcommandsForRoute (crash is intent…
cursoragent Mar 30, 2026
797b15b
revert: restore original eager Map assignment in getSubcommandsForRoute
cursoragent Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/arg-parsing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ export function parseSpanDepth(input: string): number {
return 0;
}
const n = Number(input);
if (Number.isNaN(n)) {
if (Number.isNaN(n) || n < 0) {
return DEFAULT_SPAN_DEPTH;
}
return n;
Expand Down
10 changes: 9 additions & 1 deletion src/lib/db/pagination.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,15 @@ export function getPaginationState(
return;
}

const stack = JSON.parse(row.cursor_stack) as string[];
let stack: string[];
try {
stack = JSON.parse(row.cursor_stack) as string[];
} catch {
db.query(
"DELETE FROM pagination_cursors WHERE command_key = ? AND context = ?"
).run(commandKey, contextKey);
return;
}
return { stack, index: row.page_index };
}

Expand Down
Loading