Skip to content

chore: Enable Craft auto changelog#33

Merged
timfish merged 1 commit intomainfrom
timfish/ci/craft-changelog-policy
Apr 2, 2026
Merged

chore: Enable Craft auto changelog#33
timfish merged 1 commit intomainfrom
timfish/ci/craft-changelog-policy

Conversation

@timfish
Copy link
Copy Markdown
Collaborator

@timfish timfish commented Apr 1, 2026

Would be nice to have auto generated changelogs!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • (security) Replace execSync with execFileSync to prevent command injection by fix-it-felix-sentry in #30

Internal Changes 🔧

Release

  • Fix changelog-preview permissions by BYK in #29
  • Bump Craft version to fix issues by BYK in #27
  • Switch from action-prepare-release to Craft by BYK in #25

Other

  • Enable Craft auto changelog by timfish in #33
  • Pin GitHub Actions to full-length commit SHAs by joshuarli in #31
  • Use pull_request_target for changelog preview by BYK in #28
  • macos-13 deprecation by timfish in #26

🤖 This preview updates automatically when you update the PR.

@timfish timfish requested a review from Lms24 April 2, 2026 08:58
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Autofix Details

Bugbot Autofix prepared fixes for both issues found in the latest run.

  • ✅ Fixed: Node 25 musl builds use wrong Node version container
    • Updated both x64 and arm64 musl Node 25 builds to use node:25-alpine3.23 container instead of node:24-alpine3.20.
  • ✅ Fixed: Node 25 missing from test matrix
    • Added Node 25 to the test matrix so ABI 141 binaries will be tested across all platforms in CI.

Create PR

Or push these changes by commenting:

@cursor push 7ba805db96
Preview (7ba805db96)
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -76,7 +76,7 @@
             node: 24
             binary: linux-x64-musl-137
           - os: ubuntu-22.04
-            container: node:24-alpine3.20
+            container: node:25-alpine3.23
             node: 25
             binary: linux-x64-musl-141
 
@@ -125,7 +125,7 @@
             binary: linux-arm64-musl-137
           - os: ubuntu-22.04
             arch: arm64
-            container: node:24-alpine3.20
+            container: node:25-alpine3.23
             node: 25
             binary: linux-arm64-musl-141
 
@@ -353,7 +353,7 @@
             macos-15-intel, # macOS x64
             windows-latest,
           ]
-        node: [18, 20, 22, 24]
+        node: [18, 20, 22, 24, 25]
     steps:
       - name: Check out current commit
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

@timfish timfish marked this pull request as draft April 2, 2026 09:08
@timfish timfish marked this pull request as draft April 2, 2026 09:08
@timfish timfish marked this pull request as draft April 2, 2026 09:08
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@timfish timfish force-pushed the timfish/ci/craft-changelog-policy branch from c5d367a to 345fbf0 Compare April 2, 2026 09:10
@timfish timfish marked this pull request as ready for review April 2, 2026 09:10
Copy link
Copy Markdown
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good! LMK if the versioning detection works reliably!

@timfish timfish merged commit 9de9147 into main Apr 2, 2026
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants