Open
Conversation
Member
wmak
commented
Apr 1, 2026
wmak
commented
- Add the same combinator to our per_second and per_minute formulas
- Do a best effort to fix _get_rate_unit
- use function regex instead of just doing starts with
- use arithmetic parsing instead of doing starts with
- arithmetic units are still wrong... but we currently need it for the frontend
- Add the same combinator to our per_second and per_minute formulas - Do a best effort to fix _get_rate_unit - use function regex instead of just doing starts with - use arithmetic parsing instead of doing starts with - arithmetic units are still wrong... but we currently need it for the frontend
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
| from sentry.api.serializers.snuba import SnubaTSResultSerializer | ||
| from sentry.api.utils import handle_query_errors | ||
| from sentry.discover.arithmetic import is_equation, strip_equation | ||
| from sentry.discover.arithmetic import is_equation, parse_arithmetic, strip_equation |
Contributor
There was a problem hiding this comment.
Fix attempt detected (commit b5cdf2e)
The commit refactored _get_rate_unit to call parse_arithmetic without exception handling, which was the core issue reported, but failed to wrap this call in the try/except block that was explicitly recommended to handle ArithmeticError exceptions that can be raised during parsing.
The original issue appears unresolved. Please review and try again.
Evaluated by Warden
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.