fix: Remove deprecated http.CloseNotifier, use Request.Context().Done() in Stream#4587
Open
haesuo566 wants to merge 1 commit intogin-gonic:masterfrom
Open
fix: Remove deprecated http.CloseNotifier, use Request.Context().Done() in Stream#4587haesuo566 wants to merge 1 commit intogin-gonic:masterfrom
http.CloseNotifier, use Request.Context().Done() in Stream#4587haesuo566 wants to merge 1 commit intogin-gonic:masterfrom
Conversation
…() in Stream Summary
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4587 +/- ##
==========================================
- Coverage 99.21% 98.37% -0.85%
==========================================
Files 42 48 +6
Lines 3182 3136 -46
==========================================
- Hits 3157 3085 -72
- Misses 17 42 +25
- Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
http.CloseNotifier, use Request.Context().Done() in Stream #4586http.CloseNotifier, use Request.Context().Done() in Stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4586
http.CloseNotifierembedding from theResponseWriterinterfacew.CloseNotify()withc.Request.Context().Done()in theStreammethodMotivation
http.CloseNotifierhas been officially deprecated since Go 1.11. The Go documentation recommends usingRequest.Context()instead:Request.Context().Done()also covers a broader set of termination scenarios (timeout, cancellation) beyond just client disconnection.Changes
response_writer.gohttp.CloseNotifierembedding from theResponseWriterinterfaceCloseNotify()method fromresponseWritercontext.goStream: replaceclientGone := w.CloseNotify()withclientGone := c.Request.Context().Done()context_test.gocloseChannel chan bool+CloseNotify()inTestResponseRecorderwithcancel context.CancelFunccloseClient()to callr.cancel()instead of sending to a channelCreateTestResponseRecorder()to return(*TestResponseRecorder, *http.Request)TestContextStream,TestContextStreamWithClientGone,TestContextResetInHandlerresponse_writer_test.gohttp.CloseNotifierw.CloseNotify()panic test block