refactor(gin): migrate IP handling to net/netip package#4599
Open
shirshendubhowmick wants to merge 2 commits intogin-gonic:masterfrom
Open
refactor(gin): migrate IP handling to net/netip package#4599shirshendubhowmick wants to merge 2 commits intogin-gonic:masterfrom
net/netip package#4599shirshendubhowmick wants to merge 2 commits intogin-gonic:masterfrom
Conversation
fcddb13 to
d27dab6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4599 +/- ##
==========================================
- Coverage 99.21% 98.43% -0.78%
==========================================
Files 42 48 +6
Lines 3182 3133 -49
==========================================
- Hits 3157 3084 -73
- Misses 17 40 +23
- Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced usage of
net.IPwithnet/netipKey reasons (as per official go doc):
In short it's more modern & better alternative than
net.IP. The changes here are non breaking change and backward compatible.