JS: Add class harness to recover localFieldStep edges#18302
Closed
asgerf wants to merge 4 commits intogithub:js/shared-dataflow-branchfrom
Closed
JS: Add class harness to recover localFieldStep edges#18302asgerf wants to merge 4 commits intogithub:js/shared-dataflow-branchfrom
asgerf wants to merge 4 commits intogithub:js/shared-dataflow-branchfrom
Conversation
This lets us place some more logic outside of the giant DataFlowPrivate file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synthesizes a callable for each class, which invokes the class constructor and every
instance method with the same value of
this.This ensures flow between methods in a class when the source originated "within the class",
but not when the flow into the field came from an argument.
For example:
The class harness for a class
Ccan roughly be thought of as the following code:This is realized with the following data flow graph:
Evaluation shows an 85% slowdown in vscode, so more work is needed before this can be merged.