Draft
Conversation
fjaeckel
reviewed
Apr 1, 2026
|
|
||
| begin_fold "Preparing Docker build environment" | ||
| ( | ||
| docker build -t glb-director-build-noble -f script/Dockerfile.noble script |
Contributor
There was a problem hiding this comment.
Suggested change
| docker build -t glb-director-build-noble -f script/Dockerfile.noble script | |
| docker build -t glb-director-build -f script/Dockerfile.noble script |
instead of copying the whole script, can we please move towards a parameterized version of it to pass the OS flavor as a argument and make this more dynamic?
fjaeckel
requested changes
Apr 1, 2026
Contributor
fjaeckel
left a comment
fjaeckel
left a comment
There was a problem hiding this comment.
please move towards a parameterised version of cibuild for choosing the OS flavor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.