Skip to content

github-markup: display basename instead of entire $0#1131

Merged
kivikakk merged 1 commit intomasterfrom
display_base_executable_name
Nov 27, 2017
Merged

github-markup: display basename instead of entire $0#1131
kivikakk merged 1 commit intomasterfrom
display_base_executable_name

Conversation

@mistydemeo
Copy link
Copy Markdown
Contributor

The $0 in the usage text will be the full path when being executed via an rbenv shim, which leads to excessively long help text. For example, here's what the help text looks like for calling github-markdown with no arguments.

Before:

usage: /Users/mistydemeo/.rbenv/versions/2.4.2/bin/github-markup FILE [ FILES ... ]

After:

usage: github-markup FILE [ FILES ... ]

@mistydemeo mistydemeo requested a review from kivikakk November 27, 2017 04:19
Copy link
Copy Markdown
Contributor

@kivikakk kivikakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@kivikakk
Copy link
Copy Markdown
Contributor

(We also have to accept the CLA. \o/)

@kivikakk
Copy link
Copy Markdown
Contributor

Build errors are unrelated; fixing them up in #593.

@mistydemeo
Copy link
Copy Markdown
Contributor Author

(We also have to accept the CLA. \o/)

Hah, I was wondering about that!

Travis looks unhappy for reasons unrelated to this PR.

@kivikakk
Copy link
Copy Markdown
Contributor

Travis looks unhappy for reasons unrelated to this PR.

Yeah, we didn't respond in time to the migration onto trusty, and we still depend on that a PPA only packaged for precise 😥 Will merge this now since it's all good.

@kivikakk kivikakk merged commit 00c6b8c into master Nov 27, 2017
@kivikakk kivikakk deleted the display_base_executable_name branch November 27, 2017 04:26
@krzysztof293
Copy link
Copy Markdown

Travis looks unhappy for reasons unrelated to this PR.

Yeah, we didn't respond in time to the migration onto trusty, and we still depend on that a PPA only packaged for precise 😥 Will merge this now since it's all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants