fix(util): Handle 'Finding sources' messages in RemoteProgress#282
Merged
Byron merged 2 commits intogitpython-developers:masterfrom Apr 16, 2015
matt-jordan:remote_source
Merged
fix(util): Handle 'Finding sources' messages in RemoteProgress#282Byron merged 2 commits intogitpython-developers:masterfrom matt-jordan:remote_source
Byron merged 2 commits intogitpython-developers:masterfrom
matt-jordan:remote_source
Conversation
When running a long running operation (such as a clone on a large repo), Git may return a message indicating that it is 'Finding sources'. Since there is no bit field value for this message, this causes a large amount of error messages to be emitted to stderr. This patch fixes this by adding another bit field value for this message, FINDING_SOURCES. Derived classes can look for this op_code and handle it appropriately.
Member
|
Thank you ! It seems it wasn't actually tested locally though. Setting |
Contributor
Author
|
Eek. Sorry about that - I had originally made the change in another branch, and did a poor copy over to the new branch. Whoops. |
The previous patch failed to update the expected number of op_codes, which would result in an exception when creating an instance of RemoteProgress. This patch corrects the value to the new expected number of op_codes (8)
Contributor
Author
|
The flake8 error is complaining about the length of the line. I don't normally like using '', but would the following be acceptable: I'd be happy with any other suggestion for wrapping that line. |
Contributor
Author
|
I'm not sure I know what is occurring with this test: If you can give me a hint, I'd be happy to go in and fix it. |
Member
|
Thanks, I will take it from here :). You can watch the development stream on youtube. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running a long running operation (such as a clone on a large repo),
Git may return a message indicating that it is 'Finding sources'. Since
there is no bit field value for this message, this causes a large amount
of error messages to be emitted to stderr.
This patch fixes this by adding another bit field value for this
message, FINDING_SOURCES. Derived classes can look for this op_code and
handle it appropriately.