refactor(cli): improve error handling for local script reading

.size-limit.json

@@ -33,7 +33,7 @@
       "build/globals.js",
       "build/deno.js"
     ],
-    "limit": "849.50 kB",
+    "limit": "850.00 kB",
     "brotli": false,
     "gzip": false
   },
@@ -66,8 +66,8 @@
       "README.md",
       "LICENSE"
     ],
-    "limit": "911.20 kB",
+    "limit": "912.00 kB",
     "brotli": false,
     "gzip": false
   }
-]
+]

build/cli.cjs

@@ -300,7 +300,13 @@ function readScript() {
       script = yield readScriptFromHttp(firstArg);
       tempPath = getFilepath(import_index.$.cwd, name, ext2);
     } else {
-      script = yield import_index.fs.readFile(firstArg, "utf8");
+      try {
+        script = yield import_index.fs.readFile(firstArg, "utf8");
+      } catch (err) {
+        console.error(`Error: Can't read ${firstArg}`);
+        import_node_process2.default.exitCode = 1;
+        throw new import_index.Fail(`Failed to read local script: ${firstArg} (${err.message})`);
+      }
       scriptPath = firstArg.startsWith("file:") ? import_node_url.default.fileURLToPath(firstArg) : import_index.path.resolve(firstArg);
     }
     const { ext, base, dir } = import_index.path.parse(tempPath || scriptPath);

scripts/build-clean.mjs

@@ -14,9 +14,13 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+import { fileURLToPath } from 'node:url'
+import path from 'node:path'
 import fs from 'node:fs'
 import glob from 'fast-glob'
 
+const __dirname = path.dirname(fileURLToPath(import.meta.url))
+
 const redundants = await glob(
   ['build/{repl,globals-jsr}.d.ts', 'build/{deps,internals,util,vendor*}.js'],
   {

scripts/build-dts.mjs

@@ -14,6 +14,11 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+import { fileURLToPath } from 'node:url'
+import path from 'node:path'
+
+const __dirname = path.dirname(fileURLToPath(import.meta.url))
+
 import fs from 'node:fs/promises'
 import { generateDtsBundle } from 'dts-bundle-generator'
 import glob from 'fast-glob'

scripts/build-js.mjs

@@ -27,7 +27,9 @@ import esbuildResolvePlugin from 'esbuild-plugin-resolve'
 import minimist from 'minimist'
 import glob from 'fast-glob'
 
-const __dirname = path.dirname(new URL(import.meta.url).pathname)
+import { fileURLToPath } from 'node:url'
+
+const __dirname = path.dirname(fileURLToPath(import.meta.url))
 
 const argv = minimist(process.argv.slice(2), {
   default: {

scripts/build-jsr.mjs

@@ -14,7 +14,9 @@
 
 import fs from 'node:fs'
 import path from 'node:path'
-const __dirname = path.dirname(new URL(import.meta.url).pathname)
+import { fileURLToPath } from 'node:url'
+
+const __dirname = path.dirname(fileURLToPath(import.meta.url))
 const root = path.resolve(__dirname, '..')
 const pkgJson = JSON.parse(
   fs.readFileSync(path.resolve(root, 'package.json'), 'utf-8')

scripts/build-pkgjson-lite.mjs

@@ -18,7 +18,9 @@ import fs from 'node:fs'
 import path from 'node:path'
 import { depseekSync } from 'depseek'
 
-const __dirname = path.dirname(new URL(import.meta.url).pathname)
+import { fileURLToPath } from 'node:url'
+
+const __dirname = path.dirname(fileURLToPath(import.meta.url))
 const root = path.resolve(__dirname, '..')
 const source = 'package.json'
 const dest = 'package-lite.json'

scripts/build-pkgjson-main.mjs

@@ -17,7 +17,9 @@
 import fs from 'node:fs'
 import path from 'node:path'
 
-const __dirname = path.dirname(new URL(import.meta.url).pathname)
+import { fileURLToPath } from 'node:url'
+
+const __dirname = path.dirname(fileURLToPath(import.meta.url))
 const root = path.resolve(__dirname, '..')
 const source = 'package.json'
 const dest = 'package-main.json'

scripts/build-tests.mjs

@@ -26,10 +26,12 @@ const modules = [
   ['cli', cli],
   ['index', index],
 ]
-const root = path.resolve(new URL(import.meta.url).pathname, '../..')
+import { fileURLToPath } from 'node:url'
+
+const root = path.resolve(fileURLToPath(import.meta.url), '../..')
 const filePath = path.resolve(root, `test/export.test.js`)
 
-const copyright = await fs.readFileSync(
+const copyright = fs.readFileSync(
   path.resolve(root, 'test/fixtures/copyright.txt'),
   'utf8'
 )

scripts/build-versions.mjs

@@ -17,9 +17,10 @@
 import fs from 'fs-extra'
 import path from 'node:path'
 import minimist from 'minimist'
+import { fileURLToPath } from 'node:url'
 
-const root = path.resolve(new URL(import.meta.url).pathname, '../..')
-const copyright = await fs.readFileSync(
+const root = path.resolve(fileURLToPath(import.meta.url), '../..')
+const copyright = fs.readFileSync(
   path.resolve(root, 'test/fixtures/copyright.txt'),
   'utf8'
 )

src/cli.ts

@@ -225,7 +225,15 @@ async function readScript() {
     script = await readScriptFromHttp(firstArg)
     tempPath = getFilepath($.cwd, name, ext)
   } else {
-    script = await fs.readFile(firstArg, 'utf8')
+    try {
+      script = await fs.readFile(firstArg, 'utf8')
+    } catch (err: any) {
+      console.error(`Error: Can't read ${firstArg}`)
+      process.exitCode = 1
+      throw new Fail(
+        `Failed to read local script: ${firstArg} (${err.message})`
+      )
+    }
     scriptPath = firstArg.startsWith('file:')
       ? url.fileURLToPath(firstArg)
       : path.resolve(firstArg)

test/cli.test.js

@@ -290,6 +290,13 @@ console.log(a);
     await server.stop()
   })
 
+  test('scripts from missing local file', async () => {
+    const out = await $`node build/cli.js non-existent-script.mjs`.nothrow()
+    assert.match(out.stderr, /Error: Can't read non-existent-script.mjs/)
+    assert.match(out.stderr, /Failed to read local script/)
+    assert.equal(out.exitCode, 1)
+  })
+
   test('scripts (md) from https', async () => {
     const resp = await fs.readFile(path.resolve('test/fixtures/md.http'))
     const port = await getPort()

test/extra.test.js

@@ -16,7 +16,9 @@ import assert from 'node:assert'
 import { test, describe } from 'node:test'
 import { globby, fs, path } from '../build/index.js'
 
-const __dirname = path.dirname(new URL(import.meta.url).pathname)
+import { fileURLToPath } from 'node:url'
+
+const __dirname = path.dirname(fileURLToPath(import.meta.url))
 
 describe('extra', () => {
   test('every file should have a license', async () => {