Skip to content

fix(cli): prevent command injection via ZX_* variables loaded from --env #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
l3tchupkt wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

fix(cli): prevent command injection via ZX_* variables loaded from --env #1447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,19 @@ export async function main(): Promise<void> {
if (argv.cwd) $.cwd = argv.cwd
if (argv.env) {
const envfile = path.resolve($.cwd ?? process.cwd(), argv.env)
// Security: snapshot the ZX_* keys that existed BEFORE loading the env
// file so that attacker-controlled entries (e.g. ZX_PREFIX, ZX_POSTFIX,
// ZX_SHELL) cannot pollute the execution control-plane.
const zxKeysBefore = new Set(
Object.keys(process.env).filter((k) => k.startsWith('ZX_'))
)
dotenv.config(envfile)
// Purge any ZX_* key that was not present before the env-file was loaded.
for (const k of Object.keys(process.env)) {
if (k.startsWith('ZX_') && !zxKeysBefore.has(k)) {
delete process.env[k]
}
}
resolveDefaults()
}
if (argv.verbose) $.verbose = true
Expand Down