Replace dataset id with project in datastore#1330
Merged
dhermes merged 15 commits intogoogleapis:masterfrom Jan 14, 2016
Merged
Replace dataset id with project in datastore#1330dhermes merged 15 commits intogoogleapis:masterfrom
dhermes merged 15 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
This was referenced Dec 23, 2015
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
force-pushed
the
replace-dataset-id-with-project
branch
from
739e80b to
584d44c
Compare
dhermes
force-pushed
the
replace-dataset-id-with-project
branch
3 times, most recently
from
d5b313f to
d1bcb86
Compare
This was **very** deeply intertwined with tests, so there were many residual changes as a result.
Now they all send project instead of sending dataset_id for Query and Key.
dhermes
force-pushed
the
replace-dataset-id-with-project
branch
from
d1bcb86 to
b1d4895
Compare
Contributor
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Jan 14, 2016
Replace dataset id with project in datastore
Contributor
Author
|
Merging this after #1369 caused a system test error / lint issue in the datastore system tests. Sending PR ASAP. |
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Jan 14, 2016
Causes by googleapis#1330 and googleapis#1369 crossing paths.
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
🤖 I have created a release *beep* *boop* --- ## [2.20.0](https://github.com/googleapis/google-auth-library-python/compare/v2.19.1...v2.20.0) (2023-06-12) ### Features * Add public API load_credentials_from_dict ([#1326](https://github.com/googleapis/google-auth-library-python/issues/1326)) ([5467ad7](https://github.com/googleapis/google-auth-library-python/commit/5467ad75334ee0b5e23522679171cda5fd4edb8a)) ### Bug Fixes * Expiry in compute_engine.IDTokenCredentials ([#1327](https://github.com/googleapis/google-auth-library-python/issues/1327)) ([56a6159](https://github.com/googleapis/google-auth-library-python/commit/56a6159444467717f5a5e3c04aa678bd0a5881da)), closes [#1323](https://github.com/googleapis/google-auth-library-python/issues/1323) * Expiry in impersonated_credentials.IDTokenCredentials ([#1330](https://github.com/googleapis/google-auth-library-python/issues/1330)) ([d1b887c](https://github.com/googleapis/google-auth-library-python/commit/d1b887c4bebbe4ad0df6d8f7eb6a6d50355a135d)) * Invalid `dev` version identifiers in `setup.py` ([#1322](https://github.com/googleapis/google-auth-library-python/issues/1322)) ([a9b8f12](https://github.com/googleapis/google-auth-library-python/commit/a9b8f12db0c3ff4f84939646ba0777d21e68f572)), closes [#1321](https://github.com/googleapis/google-auth-library-python/issues/1321) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
* docs: update title of pypi notebook example to reflect use of the PyPI public dataset
In response to feedback on internal change 662899733.
* feat: add support for creating a Matrix Factorization model
* feat: add support for creating a Matrix Factorization model
* Update bigframes/ml/decomposition.py
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* Update bigframes/ml/decomposition.py
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* Update bigframes/ml/decomposition.py
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* rating_col
* (nearly) complete class
* removem print()
* adding recommend
* remove hyper parameter runing references
* swap predict in _mf for recommend
* recommend -> predict
* update predict doc string
* Merge branch 'main' into b338873783-matrix-factorization
* preparing test files
* add test data
* new error: to_gbq column names need to be changed?
* Merge branch 'main' into b338873783-matrix-factorization
* Merge branch 'main' into b338873783-matrix-factorization
* Delete demo.ipynb
* passing system test
* preparing to add unit tests
* 2 out of 3 (so far) passing unit tests
* attempted mocking
* fix tests
* new test file for model creation unit tests
* add unit tests for num_factors, user_col, and item_col
* Update tests/unit/ml/test_matrix_factorization.py
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* Update tests/unit/ml/test_matrix_factorization.py
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* uncomment one test
* uncomment test
* uncomment test
* uncomment test
* nearly all tests
* tests complete and passing
* seeing if test causes kokoro failure
* uncomment test-kokoro still failing
* remove comment
* fix test
* test kokoro
* test_decomposition.py failing and now feedback_type attr does not exist
* passing tests
* Update bigframes/ml/decomposition.py
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* Update tests/system/large/ml/test_decomposition.py
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* doc attempt - _mf.py example
* feedback_type case ignore
* Update _mf.py - remove global_explain()
* fit
* W
* fix docs (maybe)
* Update test_matrix_factorization.py with updated error messages
* ilnt
* Update test_matrix_factorization.py - add 'f'
* improve errors and update tests
* Update tests/system/large/ml/test_decomposition.py
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* Update bigframes/ml/decomposition.py - num_factors error messsage
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* Update bigframes/ml/decomposition.py - user_col error message
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* Update bigframes/ml/decomposition.py - rating_col error message
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* Update bigframes/ml/decomposition.py - l2_reg error msg
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* fix tests to match updated error messages
* Update third_party/bigframes_vendored/sklearn/decomposition/_mf.py - docs df
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* Update third_party/bigframes_vendored/sklearn/decomposition/_mf.py - docs model
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* Update third_party/bigframes_vendored/sklearn/decomposition/_mf.py - docs fit
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* Update third_party/bigframes_vendored/sklearn/decomposition/_mf.py
* remove errors and tests
* Update bigframes/ml/decomposition.py
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* Update bigframes/ml/decomposition.py
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* Update bigframes/ml/decomposition.py
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* passing system test
* E AssertionError: expected call not found.
E Expected: read_gbq('SELECT * FROM ML.RECOMMEND(MODEL ..,\n (input_X_sql))', trial_id=['index_column_id'])
E Actual: read_gbq('SELECT * FROM ML.RECOMMEND(MODEL ..,\n (input_X_sql))', index_col=['index_column_id'])
* same # of elements in each
* attempt
* doc fix
* doc fix
---------
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done in advance of
v1beta3wherePartitionId.dataset_idbecomesPartitionId.project_id.@tseaver This is part of the plan in #1288. It's a bit of a mouthful, maybe you have some suggestions on how to make it easier to review? (I'm happy to make the necessary changes)
Also note that I haven't changed the use of
GCLOUD_TESTS_DATASET_IDand similar for finding the default project. IMO that should come in a separate PR. I feel that that separate PR will be complicated enough without throwing in ALL these renames. (I also realized that we only check the env. var. for the project with every other service, though we could check the App Engine ID or the Compute Engine ID as well.)