Conversation
daspecster
added
do not merge
googlebot
added
the
cla: yes
daspecster
force-pushed
the
vision-image-properties
branch
from
a08bd4e to
c741476
Compare
daspecster
force-pushed
the
vision-image-properties
branch
2 times, most recently
from
71f4e4b to
e99b0e2
Compare
daspecster
removed
the
do not merge
|
@tseaver, I cleaned this up so it should be ready to checkout as well. |
daspecster
force-pushed
the
vision-image-properties
branch
from
e99b0e2 to
acc96bc
Compare
google/cloud/vision/color.py
Outdated
|
|
||
| @property | ||
| def red(self): | ||
| """Red color. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| return self._red | ||
|
|
||
| @property | ||
| def green(self): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| """ | ||
| return self._green | ||
|
|
||
| @property |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
google/cloud/vision/color.py
Outdated
|
|
||
| :type red: int | ||
| :param red: The amount of red in the color as a value in the interval | ||
| [0, 1]. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| :param color: RGB components of the color. | ||
|
|
||
| :type score: float | ||
| :param score: Image-specific score for this color. Value in range [0, 1]. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
unit_tests/vision/_fixtures.py
Outdated
| } | ||
| } | ||
| ] | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@tseaver, updated everything except the |
|
LGTM |
daspecster
force-pushed
the
vision-image-properties
branch
from
5fdb9da to
5e0da90
Compare
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
3 participants
Based from #2319
Adds the image properties detection API for Vision.
This adds a fairly large
ImagePropertiesAnnotationwith several classes to absorb the color data in the response.✅ Also after #2319 is merged I will clean up the weird commit history.