BigQuery: Move maybe_fail_import() to top level test utils#8840
Merged
plamut merged 2 commits intogoogleapis:masterfrom Jul 31, 2019
Merged
BigQuery: Move maybe_fail_import() to top level test utils#8840plamut merged 2 commits intogoogleapis:masterfrom
plamut merged 2 commits intogoogleapis:masterfrom
Conversation
tseaver
reviewed
Jul 31, 2019
tseaver
approved these changes
Jul 31, 2019
Contributor
|
FWIW, after two years, there are exactly zero uses of |
Contributor
Author
|
Sounds like we need to run a large-scale AdWords campaign to promote its usage. @tseaver Are you suggesting that it might be better to move this back to the |
Contributor
I'm not sure. I came across it while working on googleapis/python-test-utils#43: the function has no test coverage, which meant that I had to install a development version into a virtualenv along with |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following a recent discussion, this PR moves a test utility from BigQuery to the top-level test utils, since it is considered useful outside of BigQuery, too.
How to test
Primarily verify that the promoted utility function is general enough for the promotion.